-
Notifications
You must be signed in to change notification settings - Fork 31.6k
tweet feedback button - make it hideable #7893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
While I love this feature, I think I can help with this one. :) If we can agree on a behavior, I can land a PR for this. @bpasero What do you think? |
I am not sure this scales (e.g. having an option for each and every thing in the status bar?). I would rather want to be able to e.g. right click on something in the status bar to hide it (like a Chrome extension) and then another way to bring things back to the status bar. This needs UX prep work too. |
I know what you're saying. I like the way most browsers handle this, a drag and drop based toolbar. It works really well, and gives a way to personalize the status bar. I'd really like to help with this. :) |
go to find and change it to you'll likely need to do this after every update. Caveat: worked for me, but I take no responsibility for it breaking anything important. |
It looks like the file has been moved. I edited this file (same change as above) to remove the icon: |
+1 Make it go away! |
+1 |
Would agree that we need an option for that. Alternatively, is it possible that the Tweet Feedback button to be implemented as an extension instead? It kinda reminds me of Atom's metrics plugin, which is activated by default but can be removed. |
+1 |
+1 |
Fix on (Arch) Linux is the same as above: the file is located at Has anyone looked into making an extension that can fix this? Perhaps something like this to inject custom CSS? https://github.com/be5invis/vscode-custom-css |
On arch, installing an update reverts the css file. Having a setting (preferably) or an extension (okay-ish) would be better than manually editing on every release. |
@leonadler well I guess the idiomatic Arch solution to that is to stick the following in
(This is a joke. Works for me though.) |
+1 |
3 similar comments
+1 |
+1 |
+1 |
+1 |
+1 |
I don't mind a way to provide feedback, but put it under the Help menu or something where you would expect to see something like this. It distracts me every time I look in the status bar for something... Sure we could edit the applications css file, but should we really have to? |
@herrbischoff I think you are right. Given all the thought and taste that went into designing the interface of VSCode, and reflecting on the needs and sensibilities of an audience of people that design software and user interfaces themselves, the smiley tweet feedback button sticks out like a sore thumb, and perhaps not just by accident. Everything about this UI element seems to be the decision of someone higher up in the corporate food chain with the power to overrule and vandalize the work of their hapless underlings. A hidden warning to engineers against working at MS? |
Whilst the standard O365 suite apps (Excel, Word etc) all have a smiley face with a form, somehow Microsoft Teams got away with feedback light bulb which links to https://microsoftteams.uservoice.com. No twitter required. |
I have updated the pacman hook in #7893 (comment) to reflect the current location of the CSS file so Arch users can automatically fix their editors. I am pleased to announce that this hook file is now in the Extended Support phase (Service Pack 2), meaning that I will occasionally check that the fix is still working and update it if I feel like it. Regarding @joschabach's comments, perhaps what the smiley face really represents is a product-driven commitment to expanded consumer choice. For example, it made me aware of a product niche of editors without smiley faces, so I have now properly switched to spacemacs. |
In addition to being able to hide the Feedback icon, why not settings to optionally hide any/all sections? I personally have no use for knowing that Some simple toggle settings like these would be really nice:
|
Just throwing this one-liner in here to get rid of it on macOS with a current path: sed -i '' 's/\.send-feedback{display:inline-block}/\.send-feedback{display:none}/' /Applications/Visual\ Studio\ Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.css |
^^ When I made that change & restarted the icon was gone, but then shortly after I got "Warn: Your Code installation appears to be corrupt. Please reinstall." :( |
@pzelnip: It's a one-time warning and does not hurt anything. VSCode will continue to work fine. |
VSCode updates frequently, and would have to be sanitized every time, which is not a good option. Is it feasible to fix it with a small extension (that could also customize the statusbar)? |
A pattern we've been using lately is to allow hiding of components via the context menu, it would probably make sense to be consistent in the status bar: (Copied this over from #3544) |
May I ask what's the status on this? |
Yay, thanks!On Jan 5, 2018, at 16:07, Benjamin Pasero <[email protected]> wrote:A new setting workbench.statusBar.feedback.visible was added to support this. This can also quickly be configured from a new checkbox in the feedback form itself:—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.
|
thanks, problem solved after disable the quokka extension |
I do not use Twitter, and so don't want to see the Tweet Feedback icon/smiley all the time. Add a setting to hide this, please.
The text was updated successfully, but these errors were encountered: