Skip to content

tweet feedback button - make it hideable #7893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
guidorice opened this issue Jun 20, 2016 · 39 comments
Closed

tweet feedback button - make it hideable #7893

guidorice opened this issue Jun 20, 2016 · 39 comments
Assignees
Labels
feature-request Request for new features or functionality on-testplan ux User experience issues
Milestone

Comments

@guidorice
Copy link

  • VSCode Version: 1.2.1
  • OS Version: OS X 10.9.5

I do not use Twitter, and so don't want to see the Tweet Feedback icon/smiley all the time. Add a setting to hide this, please.

@dbaeumer dbaeumer added workbench feature-request Request for new features or functionality labels Jun 20, 2016
@bpasero bpasero added this to the Backlog milestone Jun 21, 2016
@eklavyamirani
Copy link
Contributor

While I love this feature, I think I can help with this one. :)

If we can agree on a behavior, I can land a PR for this. @bpasero What do you think?

@bpasero
Copy link
Member

bpasero commented Jul 11, 2016

I am not sure this scales (e.g. having an option for each and every thing in the status bar?). I would rather want to be able to e.g. right click on something in the status bar to hide it (like a Chrome extension) and then another way to bring things back to the status bar. This needs UX prep work too.

@bpasero bpasero added the ux User experience issues label Jul 11, 2016
@eklavyamirani
Copy link
Contributor

I know what you're saying. I like the way most browsers handle this, a drag and drop based toolbar. It works really well, and gives a way to personalize the status bar.

I'd really like to help with this. :)

@smlombardi
Copy link

go to /Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.css

find .monaco-shell .statusbar-item>.dropdown.send-feedback{display:inline-block}

and change it to display:none

you'll likely need to do this after every update. Caveat: worked for me, but I take no responsibility for it breaking anything important.

@svnv
Copy link

svnv commented Jan 10, 2017

It looks like the file has been moved. I edited this file (same change as above) to remove the icon: /Applications/Visual\ Studio\ Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.css

@intheloop
Copy link

+1 Make it go away!

@olhapi
Copy link

olhapi commented May 15, 2017

+1
pls, make an option to remove that annoying icon
tweaking editor's css is not an option

@netsgnut
Copy link

Would agree that we need an option for that.

Alternatively, is it possible that the Tweet Feedback button to be implemented as an extension instead? It kinda reminds me of Atom's metrics plugin, which is activated by default but can be removed.

@joanisc
Copy link

joanisc commented Jun 27, 2017

+1
pls, make an option to remove that annoying icon
tweaking editor's css is not an option

@yuhr
Copy link

yuhr commented Jul 3, 2017

+1
Also it should be possible to send feedback on the command palette by default.

@kmoe
Copy link

kmoe commented Jul 10, 2017

Fix on (Arch) Linux is the same as above: the file is located at /opt/visual-studio-code/resources/app/out/vs/workbench/electron-browser/workbench.main.css.

Has anyone looked into making an extension that can fix this? Perhaps something like this to inject custom CSS? https://github.com/be5invis/vscode-custom-css

@leonadler
Copy link

On arch, installing an update reverts the css file. Having a setting (preferably) or an extension (okay-ish) would be better than manually editing on every release.

@kmoe
Copy link

kmoe commented Jul 11, 2017

@leonadler well I guess the idiomatic Arch solution to that is to stick the following in /usr/share/libalpm/hooks/visual-studio-code.hook to tweak the file after each package update:

[Trigger]
Operation = Install
Operation = Upgrade
Type = File
Target = opt/visual-studio-code/resources/app/out/vs/workbench/workbench.main.css

[Action]
Description = Removing smiles...
Exec = /bin/bash -c 'read -r f; sed -i 's/\.send-feedback{display:inline-block}/\.send-feedback{display:none}/' $f;' 
When = PostTransaction
NeedsTargets

(This is a joke. Works for me though.)

@raymeibaum
Copy link

+1

3 similar comments
@ShayBox
Copy link

ShayBox commented Aug 8, 2017

+1

@ElliotGilchrist
Copy link

+1

@Zelourt
Copy link

Zelourt commented Aug 15, 2017

+1

@ProfLander
Copy link

ProfLander commented Aug 17, 2017

+1
I neither want nor need social media integration in my code editor. It's obnoxious.

@ghost
Copy link

ghost commented Aug 18, 2017

+1

@chriscarpenter12
Copy link

I don't mind a way to provide feedback, but put it under the Help menu or something where you would expect to see something like this. It distracts me every time I look in the status bar for something... Sure we could edit the applications css file, but should we really have to?

@joschabach
Copy link

@herrbischoff I think you are right. Given all the thought and taste that went into designing the interface of VSCode, and reflecting on the needs and sensibilities of an audience of people that design software and user interfaces themselves, the smiley tweet feedback button sticks out like a sore thumb, and perhaps not just by accident. Everything about this UI element seems to be the decision of someone higher up in the corporate food chain with the power to overrule and vandalize the work of their hapless underlings. A hidden warning to engineers against working at MS?

@jwigley
Copy link

jwigley commented Sep 18, 2017

Whilst the standard O365 suite apps (Excel, Word etc) all have a smiley face with a form, somehow Microsoft Teams got away with feedback light bulb which links to https://microsoftteams.uservoice.com. No twitter required.
screen shot 2017-09-18 at 1 49 35 pm

@kmoe
Copy link

kmoe commented Sep 18, 2017

I have updated the pacman hook in #7893 (comment) to reflect the current location of the CSS file so Arch users can automatically fix their editors. I am pleased to announce that this hook file is now in the Extended Support phase (Service Pack 2), meaning that I will occasionally check that the fix is still working and update it if I feel like it.

Regarding @joschabach's comments, perhaps what the smiley face really represents is a product-driven commitment to expanded consumer choice. For example, it made me aware of a product niche of editors without smiley faces, so I have now properly switched to spacemacs.

@jessejanderson
Copy link

In addition to being able to hide the Feedback icon, why not settings to optionally hide any/all sections? I personally have no use for knowing that Spaces: 2 and that my line endings are LF because those are the same for all of my projects.

Some simple toggle settings like these would be really nice:

"workbench.statusBar.showEndOfLineSequence": true,
"workbench.statusBar.showFeedbackSmiley": false,
"workbench.statusBar.showIndentation": true,

@herrbischoff
Copy link

Just throwing this one-liner in here to get rid of it on macOS with a current path:

sed -i '' 's/\.send-feedback{display:inline-block}/\.send-feedback{display:none}/' /Applications/Visual\ Studio\ Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.css

@pzelnip
Copy link

pzelnip commented Oct 16, 2017

^^ When I made that change & restarted the icon was gone, but then shortly after I got "Warn: Your Code installation appears to be corrupt. Please reinstall." :(

@herrbischoff
Copy link

herrbischoff commented Oct 16, 2017

@pzelnip: It's a one-time warning and does not hurt anything. VSCode will continue to work fine.

@joschabach
Copy link

VSCode updates frequently, and would have to be sanitized every time, which is not a good option. Is it feasible to fix it with a small extension (that could also customize the statusbar)?

@Tyriar
Copy link
Member

Tyriar commented Oct 26, 2017

A pattern we've been using lately is to allow hiding of components via the context menu, it would probably make sense to be consistent in the status bar:

screen shot 2017-10-25 at 10 49 15 am

screen shot 2017-10-25 at 10 49 21 am

(Copied this over from #3544)

@verpixelt
Copy link

May I ask what's the status on this?

@bpasero bpasero assigned bpasero and unassigned seanmcbreen Jan 5, 2018
@bpasero bpasero modified the milestones: Backlog, December 2017/January 2018 Jan 5, 2018
@bpasero bpasero closed this as completed in 840587c Jan 5, 2018
@bpasero
Copy link
Member

bpasero commented Jan 5, 2018

A new setting workbench.statusBar.feedback.visible was added to support this. This can also quickly be configured from a new checkbox in the feedback form itself:

image

...or from a new context menu:

image

@joschabach
Copy link

joschabach commented Jan 5, 2018 via email

@zhaomiing
Copy link

zhaomiing commented Feb 8, 2018

but the placeholder width is still there, can we guys remove that too? which should give us a correct align.
image

@bpasero
Copy link
Member

bpasero commented Feb 8, 2018

Not for me:

image

Maybe try a restart, it should be fine.

@zhaomiing
Copy link

thanks, problem solved after disable the quokka extension

@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality on-testplan ux User experience issues
Projects
None yet
Development

No branches or pull requests