Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accesibility mode only keybindings to navigate up and down rows in the terminal #76050

Closed
Tyriar opened this issue Jun 25, 2019 · 3 comments · Fixed by #77252
Closed

Add accesibility mode only keybindings to navigate up and down rows in the terminal #76050

Tyriar opened this issue Jun 25, 2019 · 3 comments · Fixed by #77252
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality terminal Integrated terminal issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 25, 2019

For example when in accessibility mode, ctrl+up/down could navigate (focus) through rows in the terminal.

@Tyriar Tyriar added feature-request Request for new features or functionality accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues terminal Integrated terminal issues labels Jun 25, 2019
@Tyriar Tyriar added this to the July 2019 milestone Jun 25, 2019
@Tyriar Tyriar self-assigned this Jun 25, 2019
@Tyriar
Copy link
Member Author

Tyriar commented Jul 8, 2019

Required for this: xtermjs/xterm.js#2294

Tyriar added a commit that referenced this issue Jul 8, 2019
Diff: xtermjs/xterm.js@f235d70...44a843b

Changes:

- Parser sub-parameters/colon notation
- Webgl simplify atlas/fix npe
- Move sound into browser
- Fix keyup event (related #76050)
Tyriar added a commit that referenced this issue Jul 8, 2019
@Tyriar Tyriar added the verification-needed Verification of issue is requested label Jul 29, 2019
@Tyriar
Copy link
Member Author

Tyriar commented Jul 29, 2019

To verify test with JAWS 2019 under Windows. ctrl+up/ctrl+down enters line navigation mode and escape exits. JAWS is going to add special rules for this, it may not be done yet but you can create the following file to fix the keybindings.

C:\Users\<user>\AppData\Roaming\Freedom Scientific\JAWS\2019\Settings\enu\defaults.jkm:

[Common Keys]
Ctrl+UpArrow=
Ctrl+DownArrow=

Note that accessibility must be enabled to test this, you can also define your own keybindings for the commands

workbench.action.terminal.navigationModeExit
workbench.action.terminal.navigationModeFocusNext
workbench.action.terminal.navigationModeFocusPrevious

@kieferrm kieferrm added the verified Verification succeeded label Aug 1, 2019
@kieferrm
Copy link
Member

kieferrm commented Aug 1, 2019

I had to change the keybinding to Ctrl+Shift+Up/Down. It didn't work reliably with JAWS but it worked fine when JAWS was not running and the workbench was in accessibility mode.

When starting JAWS, focussing the terminal, and entering navigation mode, things were as expected. However pressing ESC put JAWS into a navigation mode, I don't know how to get out off and in that mode the keybindings don't work.

@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality terminal Integrated terminal issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
2 participants