Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strict null check workbench/contrib/terminal #69686

Closed
mjbvz opened this issue Mar 2, 2019 · 0 comments · Fixed by #69814
Closed

Strict null check workbench/contrib/terminal #69686

mjbvz opened this issue Mar 2, 2019 · 0 comments · Fixed by #69814
Assignees
@Tyriar
Labels
debt Code quality issues terminal General terminal issues that don't fall under another label
Milestone
March 2019

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Mar 2, 2019

Part of #60565

Tracks updating vs/workbench/contrib/terminal to have strict null checking.

Not all of these files are eligible to be included in the strict null build yet due to their dependencies. You do not need to fix errors outside of the contrib/terminal directory

Steps

  1. Add ./vs/workbench/contrib/terminal/**/*.ts to the include section of src/tsconfig.strictNullChecks.json
  2. Run yarn strict-null-check -- --watch
  3. Fix strict null check compiler errors inside of the contrib/terminal directory.
  4. Verify normal build still works
  5. Revert changes to src/tsconfig.strictNullChecks.json
@mjbvz mjbvz added the debt Code quality issues label Mar 2, 2019
@Tyriar Tyriar added this to the March 2019 milestone Mar 2, 2019
@Tyriar Tyriar added the terminal General terminal issues that don't fall under another label label Mar 2, 2019
Tyriar added a commit that referenced this issue Mar 5, 2019
@Tyriar
Strict null check contrib/terminal
d93221d 
Fixes #69686
@Tyriar Tyriar mentioned this issue Mar 5, 2019
Merged
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
debt Code quality issues terminal General terminal issues that don't fall under another label
Projects
None yet
Milestone
March 2019
Development

Successfully merging a pull request may close this issue.

Strict null check contrib/terminal microsoft/vscode
2 participants
@Tyriar @mjbvz