Debugging Hangs when default terminal app doesn't exist

[pieandcakes]

To test: Set Terminal.External.LinuxExec to an app that doesn't exist.

Start debugging with external terminal (I used the C++ extension and set externalConsole to true).

Expected:

Failure response for RunInTerminal command.

Actual:
No Response from VS Code's debugadapter protocol.
UI looks like it is waiting for debugging to start.

[therealkenc]

Ref some background information as it pertains to folks using native VS Code on WSL here. It might be that the console/terminal application doesn't exist, as the steps above and issue title suggest. More typically the x-terminal-emulator app (on Ubuntu, usually gnome-terminal) exists aight, but can fail to run for reasons which are easy to trip over in our quirky environment. Any feedback the user can get (even the nonzero error code returned from the app) would go a long way.

[pieandcakes]

@weinand This is becoming a bigger issue especially in the VS Code remote scenario as it doesn't fail with a good message to the user. Can we prioritize this to be fixed?

[weinand]

@pieandcakes this issue had been partially addressed in VS Code but it still needs some work on the extension side. Please see microsoft/vscode-remote-release#381.

[weinand]

@pieandcakes I've fixed the broken link...

[pieandcakes]

Thanks. I look forward to testing it.

[therealkenc]

Heads up I am still seeing situations where you get the "hang" with externalConsole=false (the internal console) but the external console works fine. This is on 1.35.0-insider 2019-05-17 on Real Linux Ubuntu to Real Linux Ubuntu with Remote SSH, but I saw the behavior last December-February too without inviting Remote to the party. Unfortunately it is really hard to give definitive repro steps to get in that state, because there are so many moving parts. And I know that doesn't help you. I am hoping that whatever error UX is forthcoming might shed some light. Mentioning it because if I've hit it you'll probably hear from someone else eventually too.