Remote - SSH with runInTerminal set to type external hangs

[WardenGnaw]

Issue Type: Bug

Steps

Reproduce with a simple cpp app with VS Code Remote + C/C++ Extension.
Use default launch.json with externalConsole set to type: external and it will hang.
We have seen this issue occur from windows or macOS host to a linux remote machine

Question

Does VS Code launch an external terminal if runInTerminal is set to false for Remote - SSH?
The debug adapter is sending a runInTerminal request and it seems like we never get a response.

code --status

Version: Code 1.35.0 (553cfb2c2205db5f15f3ee8395bbd5cf066d357d, 2019-06-04T01:17:12.481Z)
OS Version: Windows_NT x64 10.0.18362
CPUs: Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz (8 x 3408)
Memory (System): 31.92GB (1.77GB free)
VM: 0%
Screen Reader: no
Process Argv:
GPU Status: 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: enabled
surface_synchronization: enabled_on
video_decode: enabled
webgl: enabled
webgl2: enabled

CPU % Mem MB PID Process
0 86 562564 code main
0 74 21628 shared-process
1 91 544344 gpu-process
2 187 575512 window (launch.json - cpp [SSH: <REMOTE_HOST> ] - Visual Studio Code)
0 41 559840 "C:\Program Files\Microsoft VS Code\Code.exe" "c:\Program Files\Microsoft VS Code\resources\app\out\bootstrap-fork" ms-vscode.cppdbg "{"common.vscodemachineid":"73bcf51fda6512b3fa6013ddd7d39bbbba9f259b9079973fff278d897b5b0e84","common.vscodesessionid":"c43383f6-99af-4e73-a382-f52a845fbbd31560804080530"}" AIF-d9b70cd4-b9f9-4d70-929b-a071c400b217
0 60 574600 extensionHost
0 8 574476 ssh <REMOTE_HOST> -N -L localhost:40024:localhost:44443

Fetching remote diagnostics for 'SSH: <REMOTE_HOST> ' failed: Command failed: "/home//.vscode-server/bin/553cfb2c2205db5f15f3ee8395bbd5cf066d357d/out/vs/base/node/cpuUsage.sh" 8884

VS Code version: Code 1.35.0 (553cfb2c2205db5f15f3ee8395bbd5cf066d357d, 2019-06-04T01:17:12.481Z)
OS version: Windows_NT x64 10.0.18362
Remote OS version: Linux x64 4.18.0-21-generic

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz (8 x 3408)
GPU Status	2d_canvas: enabled checker_imaging: disabled_off flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: disabled_software rasterization: enabled surface_synchronization: enabled_on video_decode: enabled webgl: enabled webgl2: enabled
Load (avg)	undefined
Memory (System)	31.92GB (2.27GB free)
Process Argv
Screen Reader	no
VM	0%

Item	Value
Remote	SSH: <REMOTE_HOST>
OS	Linux x64 4.18.0-21-generic
CPUs	Intel(R) Core(TM) i7-4790 CPU @ 3.60GHz (2 x 3591)
Memory (System)	7.79GB (2.85GB free)
VM	0%

Extensions (7)

Extension	Author (truncated)	Version
remote-containers	ms-	0.59.0
remote-ssh	ms-	0.42.0
remote-ssh-edit	ms-	0.42.0
remote-ssh-explorer	ms-	0.42.0
remote-wsl	ms-	0.38.0
vscode-remote-extensionpack	ms-	0.15.0
cpptools	ms-	0.23.1

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• 1.33.1 Update keeps crashing in windows 10 32 bit (#73096)

[weinand]

@WardenGnaw this is a duplicate of microsoft/vscode#67296, correct?
And you've seen #381?

[WardenGnaw]

@weinand I believe this is different from microsoft/vscode#67296. I have xterm set as my default linuxExec and it is also installed on my Ubuntu 18.04 instance and it still hangs.

[Chuxel]

@weinand This got raised over in vscode-dev-containers as well. It looks like we might now hang in if external console is set instead of erroring. Easy to repro with latest insiders from what I have seen.

[vscodebot]

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!