Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multiple integrated terminals #6458

Closed
Tyriar opened this issue May 18, 2016 · 5 comments
Closed

Support multiple integrated terminals #6458

Tyriar opened this issue May 18, 2016 · 5 comments
Assignees
@Tyriar
Labels
feature-request Request for new features or functionality terminal Integrated terminal issues
Milestone
June 2016

Comments

@Tyriar
Copy link
Member

Tyriar commented May 18, 2016

Integrated terminal master issue: #143
@Tyriar Tyriar added feature-request Request for new features or functionality terminal Integrated terminal issues labels May 18, 2016
@Tyriar Tyriar self-assigned this May 18, 2016
This was referenced May 18, 2016
Closed
Closed
Closed
@Tyriar
Copy link
Member Author

Tyriar commented May 24, 2016

From @bpasero in #6708

I think pretty early on we will get the feature request to support multiple terminals. As soon as you run a program from the terminal, you cannot use it anymore.

Maybe we just allow to create new terminals with an action from the terminal panel and show all opened terminals from a dropdown similar to output channels?

We did this in Monaco on Azure:

e747b8e8-2180-11e6-999f-0e6a822cb5c3

@Tyriar Tyriar mentioned this issue Jun 1, 2016
Closed
@Tyriar Tyriar added this to the June 2016 milestone Jun 3, 2016
@Tyriar Tyriar mentioned this issue Jun 3, 2016
Merged
Tyriar added a commit that referenced this issue Jun 4, 2016
@Tyriar
Pull individual terminal logic out of terminalPanel
fb06e53 
The character measure logic has been shuffled around a little and now is done
primarily in setVisible after the terminal is confirmed to be within the DOM.

Part of #6458
@Tyriar Tyriar mentioned this issue Jun 4, 2016
Closed
aeschli pushed a commit that referenced this issue Jun 6, 2016
@Tyriar @aeschli
Pull individual terminal logic out of terminalPanel
d87ec53 
The character measure logic has been shuffled around a little and now is done
primarily in setVisible after the terminal is confirmed to be within the DOM.

Part of #6458
@Tyriar Tyriar mentioned this issue Jun 8, 2016
Closed
Tyriar added a commit that referenced this issue Jun 9, 2016
@Tyriar
Handle an array of TerminalInstance's
f3fb6c4 
Part of #6458
@Tyriar
Copy link
Member Author

Tyriar commented Jun 10, 2016

I created an issue to look at after this for splitting the terminal panel so you can see multiple at once #7504

@Tyriar
Copy link
Member Author

Tyriar commented Jun 24, 2016

Fixed in #7705, should land in Insiders in 1-2 hours.

image

@Tyriar Tyriar closed this as completed Jun 24, 2016
@davidanthoff davidanthoff mentioned this issue Jun 24, 2016
Closed
@davidanthoff
Copy link
Contributor

I see that UI now on Windows. The drop down shows things like "1: xterm". Why "xterm"? I'm using PowerShell, might make more sense if that term shows up (like "bash" in your screen shot).

@Tyriar
Copy link
Member Author

Tyriar commented Jun 24, 2016

@davidanthoff thanks for the quick feedback, I'll see if I can look at this for June #8116

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
feature-request Request for new features or functionality terminal Integrated terminal issues
Projects
None yet
Milestone
June 2016
Development

No branches or pull requests
2 participants
@davidanthoff @Tyriar