Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML attribute/attribute-value completion documentation #63955

Closed
octref opened this issue Nov 28, 2018 · 3 comments
Closed

HTML attribute/attribute-value completion documentation #63955

octref opened this issue Nov 28, 2018 · 3 comments
Assignees
@octref
Labels
feature-request Request for new features or functionality html HTML support issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
July 2019

Comments

@octref
Copy link
Contributor

octref commented Nov 28, 2018

We have no documentation for HTML attribute completions:

image

No documentation for HTML attribute value completions either:

image

As we progress in #62976, these should be implemented so custom tag/attribute providers could offer a good experience.

MDN actually has neat descriptions for all of them:
@octref octref added feature-request Request for new features or functionality html HTML support issues labels Nov 28, 2018
@octref octref added this to the Backlog milestone Nov 28, 2018
@octref octref self-assigned this Nov 28, 2018
octref added a commit to microsoft/vscode-html-languageservice that referenced this issue Jan 15, 2019
@octref
Refactor custom data support.
4773ebb 
Changes:

- Feature: HTML attribute completion documentation
- Rename: tagProvider -> dataProvider
- API: Now in sync with CSS LS API
- HTMLTagSpecification converted to serializable plain data structure
so does attributes and attribute values
- Remove Angular1/Ionic1 support
- Remove i18n for HTML tags, and manage them in a plain JSON-like file because
  - We don't have i18n support in LSP yet
  - There's no translation yet
  - The JSON-like file is typed and can be easily mainaintaed
  - We'll start pulling data from W3C HTML spec and MDN to do features
  such as short descriptions, browser support table adn syntax. Such
  plain JSON-like files are easy to auto-generate.
  - Unblocks #12, #30, #44

Fixes:

- Fix microsoft/vscode#2784
- Part of microsoft/vscode#63955 (no CompletionItem.documentation for attr value yet)
octref added a commit to microsoft/vscode-html-languageservice that referenced this issue Jan 15, 2019
@octref
Refactor custom data support.
c3b860b 
Changes:

- Feature: HTML attribute completion documentation
- Rename: tagProvider -> dataProvider
- API: Now in sync with CSS LS API
- HTMLTagSpecification converted to serializable plain data structure
so does attributes and attribute values
- Remove Angular1/Ionic1 support
- Remove i18n for HTML tags, and manage them in a plain JSON-like file because
  - We don't have i18n support in LSP yet
  - There's no translation yet
  - The JSON-like file is typed and can be easily mainaintaed
  - We'll start pulling data from W3C HTML spec and MDN to do features
  such as short descriptions, browser support table adn syntax. Such
  plain JSON-like files are easy to auto-generate.
  - Unblocks #12, #30, #44

Fixes:

- Fix microsoft/vscode#2784
- Part of microsoft/vscode#63955 (no CompletionItem.documentation for attr value yet)
@octref octref mentioned this issue Jan 15, 2019
Merged
@octref octref modified the milestones: Backlog, February 2019 Feb 6, 2019
@octref
Copy link
Contributor Author

octref commented Feb 6, 2019

The support is available, but we still need pulling more data: microsoft/vscode-html-languageservice#44

@octref octref modified the milestones: February 2019, March 2019 Feb 25, 2019
@octref
Copy link
Contributor Author

octref commented Feb 25, 2019

Attribute description is there in #69318, attribute value not yet. Will continue on March.

@octref octref modified the milestones: March 2019, April 2019 Mar 22, 2019
@octref octref modified the milestones: April 2019, May 2019 Apr 8, 2019
@octref octref modified the milestones: May 2019, June 2019 May 24, 2019
@octref octref modified the milestones: June 2019, July 2019 Jun 24, 2019
@octref octref mentioned this issue Jul 8, 2019
Closed
7 tasks
@octref
Copy link
Contributor Author

octref commented Jul 29, 2019

Fixed.

@octref octref closed this as completed Jul 29, 2019
@roblourens roblourens added the verification-needed Verification of issue is requested label Jul 30, 2019
@lramos15 lramos15 added the verified Verification succeeded label Jul 30, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@octref octref

Labels
feature-request Request for new features or functionality html HTML support issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
July 2019
Development

No branches or pull requests
3 participants
@roblourens @octref @lramos15