-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use WSL.exe instead of bash.exe #51455
Comments
Just replacing
which is running fine with |
I'm not really sure whether it is necessary to use "wsl.exe" in the node debugger because it is only used to run single commands on the linux side. It is not used to launch an interactive shell. So a user is not seeing this shell at all. I think we only have to use wsl.exe if we cannot rely on bash.exe being always available. I've send a question about this to the WSL team. |
My fix replaces not only bash.exe with wsl.exe but it also changes the arguments passed to wsl.exe to an array instead of a single string. |
Since bash.exe isn't removed anytime soon, we will not switch to wsl.exe. |
We encourage to use WSL.exe for distro management and for launching WSL. But, the current VS Code integration uses the original implementation - bash.exe. This is problematic as new distros that are not dependent on bin/bash come to WSL.
We propose changing 'bash.exe' references to 'WSL.exe' in VS Code.
The text was updated successfully, but these errors were encountered: