Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use WSL.exe instead of bash.exe #51455

Closed
weinand opened this issue Jun 8, 2018 · 5 comments
Closed

use WSL.exe instead of bash.exe #51455

weinand opened this issue Jun 8, 2018 · 5 comments
Assignees
Labels
debt Code quality issues debug Debug viewlet, configurations, breakpoints, adapter issues

Comments

@weinand
Copy link
Contributor

weinand commented Jun 8, 2018

We encourage to use WSL.exe for distro management and for launching WSL. But, the current VS Code integration uses the original implementation - bash.exe. This is problematic as new distros that are not dependent on bin/bash come to WSL.

We propose changing 'bash.exe' references to 'WSL.exe' in VS Code.

@weinand weinand added debug Debug viewlet, configurations, breakpoints, adapter issues debt Code quality issues labels Jun 8, 2018
@weinand weinand added this to the June 2018 milestone Jun 8, 2018
@weinand
Copy link
Contributor Author

weinand commented Jun 8, 2018

Just replacing bash.exewith wsl.exe doesn't work because wsl chokes on the following:

wsl -c node --version

which is running fine with bash.

@weinand
Copy link
Contributor Author

weinand commented Jun 8, 2018

@weinand
Copy link
Contributor Author

weinand commented Jun 8, 2018

I'm not really sure whether it is necessary to use "wsl.exe" in the node debugger because it is only used to run single commands on the linux side. It is not used to launch an interactive shell. So a user is not seeing this shell at all.

I think we only have to use wsl.exe if we cannot rely on bash.exe being always available.

I've send a question about this to the WSL team.

weinand added a commit to microsoft/vscode-node-debug that referenced this issue Jun 8, 2018
@weinand
Copy link
Contributor Author

weinand commented Jun 8, 2018

My fix replaces not only bash.exe with wsl.exe but it also changes the arguments passed to wsl.exe to an array instead of a single string.

@weinand
Copy link
Contributor Author

weinand commented Jun 25, 2018

Since bash.exe isn't removed anytime soon, we will not switch to wsl.exe.

@weinand weinand closed this as completed Jun 25, 2018
@weinand weinand removed this from the June 2018 milestone Jun 25, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues debug Debug viewlet, configurations, breakpoints, adapter issues
Projects
None yet
Development

No branches or pull requests

2 participants