Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert samples to Tasks 2.0.0 #50876

Closed
15 of 19 tasks
dbaeumer opened this issue May 31, 2018 · 2 comments
Closed
15 of 19 tasks

Convert samples to Tasks 2.0.0 #50876

dbaeumer opened this issue May 31, 2018 · 2 comments
Assignees
Labels
debt Code quality issues tasks Task system issues
Milestone

Comments

@dbaeumer
Copy link
Member

dbaeumer commented May 31, 2018

We should ensure that all samples provided under https://github.com/Microsoft/vscode-extension-samples us task version 2.0.0. Here is a small recipe how to convert a task 1.0 sample to a task 2.0.0 sample.

Package.json contains a watch script

Replace the content of the tasks.json with

// See https://go.microsoft.com/fwlink/?LinkId=733558
// for the documentation about the tasks.json format
{
    "version": "2.0.0",
    "tasks": [
        {
            "type": "npm",
            "script": "watch",
            "problemMatcher": "$tsc-watch",
            "isBackground": true,
            "presentation": {
                "reveal": "never"
            },
            "group": {
                "kind": "build",
                "isDefault": true
            }
        }
    ]
}

Add the following setting to the settings.json

    // Turn off tsc task auto detection since we have the necessary task as npm scripts
    "typescript.tsc.autoDetect": "off"

Ensure the right pre launch task in launch.json. It should be

"preLaunchTask": "npm: watch"

Package.json DOES NOT contain a watch script

Ensure the right pre launch task in launch.json. It should be

"preLaunchTask": "tsc: watch - tsconfig.json"

@Microsoft/vscode please check if you own an example and follow the steps above if an update is necessary and check yourself off the list. If you have questions please ping me.

@dbaeumer dbaeumer self-assigned this May 31, 2018
@dbaeumer dbaeumer added this to the June 2018 milestone May 31, 2018
alexdima pushed a commit to microsoft/vscode-extension-samples that referenced this issue May 31, 2018
bpasero added a commit to microsoft/vscode-extension-samples that referenced this issue May 31, 2018
@joaomoreno joaomoreno added tasks Task system issues debt Code quality issues labels Jun 25, 2018
@egamma
Copy link
Member

egamma commented Jun 25, 2018

@dbaeumer these are the workspace files that are not yet converted to tasks 2.0.0

image

@dbaeumer
Copy link
Member Author

@egamma thanks. Adapted the above samples

@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues tasks Task system issues
Projects
None yet
Development

No branches or pull requests

3 participants