Skip to content

Close empty editor group with mouse middle click #50733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tyriar opened this issue May 29, 2018 · 2 comments
Closed

Close empty editor group with mouse middle click #50733

Tyriar opened this issue May 29, 2018 · 2 comments
Assignees
@bpasero
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded workbench-editor-grid Grid layout issues in the editor area
Milestone
May 2018

Comments

@Tyriar
Copy link
Member

Tyriar commented May 29, 2018

VS Code version: Code - Insiders 1.24.0-insider (41a7c49, 2018-05-29T06:09:34.618Z)
OS version: Windows_NT x64 10.0.16299

#50458

I tried to do this without thinking about it as I use it a lot with tabs.
@Tyriar Tyriar added the workbench-editor-grid Grid layout issues in the editor area label May 29, 2018
@vscodebot vscodebot bot added the insiders label May 29, 2018
@bpasero bpasero added feature-request Request for new features or functionality and removed insiders labels May 30, 2018
@bpasero bpasero added this to the May 2018 milestone May 30, 2018
@bpasero bpasero changed the title Should middle click in an empty editor group close it? Close empty editor group with mouse middle click May 30, 2018
@bpasero bpasero closed this as completed May 30, 2018
@bpasero bpasero added the verification-needed Verification of issue is requested label May 30, 2018
bpasero added a commit that referenced this issue May 30, 2018
@bpasero
grid - allow to close empty groups via middle click (#50733)
f3e29b3
@bpasero
Copy link
Member

bpasero commented May 31, 2018

Verify via: https://az764295.vo.msecnd.net/insider/62af395b9974f38fcf15acafc8ac9818b0db7084/VSCode-darwin-insider-unsigned.zip

@Tyriar
Copy link
Member Author

Tyriar commented May 31, 2018

Verified, I notice that middle clicking in what would be the tab well doesn't work, not sure if that was by design.

@Tyriar Tyriar added the verified Verification succeeded label May 31, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded workbench-editor-grid Grid layout issues in the editor area
Projects
None yet
Milestone
May 2018
Development

No branches or pull requests
2 participants
@bpasero @Tyriar