Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visual indication of prepared rename range #48782

Closed
octref opened this issue Apr 26, 2018 · 1 comment
Closed

Visual indication of prepared rename range #48782

octref opened this issue Apr 26, 2018 · 1 comment
Assignees
@jrieken
Labels
feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code rename

Comments

@octref
Copy link
Contributor

octref commented Apr 26, 2018

Part of #48409, but also lacking in current rename:

We don't show any indication of the range that's coming back from prepareRename. Previously F2's target will always be the word under cursor -- that's easy for users to understand. Now that it could be a bit far from the cursor position, we should highlight the prepared range in some way.
@octref octref added the api label Apr 26, 2018
@jrieken jrieken added feature-request Request for new features or functionality editor-symbols definitions, declarations, references and removed api labels Apr 27, 2018
@jrieken jrieken added this to the May 2018 milestone Apr 27, 2018
@jrieken jrieken modified the milestones: May 2018, June 2018 May 17, 2018
@jrieken jrieken removed this from the June 2018 milestone Jun 12, 2018
@jrieken jrieken added rename and removed editor-symbols definitions, declarations, references labels May 21, 2019
@jrieken jrieken added the *out-of-scope Posted issue is not in scope of VS Code label Oct 7, 2019
@vscodebot
Copy link

vscodebot bot commented Oct 7, 2019

This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!

@vscodebot vscodebot bot closed this as completed Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrieken jrieken

Labels
feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code rename
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jrieken @octref