Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test RenameProvider api extensions #48409

Closed
2 tasks done
jrieken opened this issue Apr 23, 2018 · 3 comments
Closed
2 tasks done

Test RenameProvider api extensions #48409

jrieken opened this issue Apr 23, 2018 · 3 comments

Comments

@jrieken
Copy link
Member

jrieken commented Apr 23, 2018

Refs: #7340

Complexity: 2

Note that until e56aced ships with insiders you need to enable proposed-api for your test extension.

We have added a new, optional, method to the RenameProvider, namely: resolveRenameLocation. Understand what it does and implement an extension that uses this.

@jrieken jrieken assigned aeschli and mjbvz and unassigned aeschli and mjbvz Apr 23, 2018
@jrieken jrieken added this to the April 2018 milestone Apr 23, 2018
@jrieken
Copy link
Member Author

jrieken commented Apr 23, 2018

FYI - to test against the latest API do the following:

  • open your extensions package.json file
  • change the engine.vscode property to *
  • run npm run postinstall (assuming you have the vscode module as dev-dependency)
  • undo the engine-version change from step 2

@mjbvz
Copy link
Collaborator

mjbvz commented Apr 24, 2018

Blocked on testing by #48592

@mjbvz
Copy link
Collaborator

mjbvz commented Apr 26, 2018

@jrieken implementation of design looks good in my testing but @octref and I were confused by how range is used in the api design. I believe we'd like to discuss this at the API sync

@mjbvz mjbvz closed this as completed Apr 26, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants