-
Notifications
You must be signed in to change notification settings - Fork 31.8k
Audio bell does not work in integrated terminal #47711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Looks like there's an issue with the bell in the packages version of VS Code (not in the dev build):
|
This may be related to Electron https://bugs.chromium.org/p/chromium/issues/detail?id=409402, should verify after we upgrade to Electron 2. |
Not fixed in Electron 2? |
I have the same problem with this in my machine:
(Plan to use this ASCII to ring some task when the compilation is finish 😹) |
Hi, any idea when this will be fixed? I am trying to add a bell sound at the end of my grunt task. It works fine in default terminal but not in the vscode integrated terminal.
|
I can also reproduce this issue in macOS with echo -ne '\007' VS Code: 1.34.0 |
I'm seeing this too. Even with MacOS 10.14.5 |
This appears to work in the demo so I suspect it's actually a bug in vscode rather than an upstream issue. |
Works fine out of sources, in the product build I see this:
Probably related to CSP |
This is not related to CSP but because we strip out ffmpeg. |
@tjx666 it was never lacking shell integration, it's an issue with Electron sound. We seem to have worked around those since audio cues are now supported, this just needs someone to investigate and create a sound (which I've requested internally). |
FYI: it's not just the sound the built-in vscode terminal does none of those. another "fun" workaround would be to use |
On Windows you can use this as a workaround:
This will play a short beep sound, even when you're remoting into WSL. E.g. for my Rust webserver, I use this command to auto-compile the project whenever any file changes. If the compilation succeeds, the webserver starts and I hear a short beep. If the compilation fails, I hear a longer, lower beep.
|
I see last release of vscode fix some accessbility issues, the audio bell should also be a accessbility issue. I think this is a welcome feature but not hard to implement. Any plan to implement it? |
@tjx666 I agree, this was mislabeled. I was waiting on sounds from another MS team before continuing which seems to have stalled so I pinged them again. |
it's been a long road. getting from there to here. |
Thank you. How long would it take to have it in the main Vscode version(not insiders) ? |
we will release this version in a few weeks @nnWhisperer |
Is this supposed to be resolved as of 1.72.2 (commit d045a5e)? If so, it is not working for me on macOS 10.15.7; running |
You need to opt in w the setting for it to work (it's off by default) |
The audio bell works on my computer! |
Found myself on Enable with Can also use "terminal.integrated.enableBell": true Moving forward |
Thanks all, it's working now. However, it doesn't use the alert sound I have configured on my Mac ("Glass" ding in System Sounds), and the "bloop" sound that VSCode uses is much too quiet; I have to turn my volume up to 100% for it to be at the same level as the Glass sound at 25%. Is there a way to adjust the volume level and/or the audio file that is played? |
My old work-around on mac was: |
@denishowew For getting notified when a command/script finishes, I've been using |
Diff: xtermjs/xterm.js@d9f58c0...f30c38f - Fix edge case in text decoder - mp3 sound, fixes microsoft#47711 - New column sequences - Limit parse buffer size - -1 disposed markers - Remove obsolete mouse encodings - Refine IViewportRange - Apply scrollSensitivity to fast scroll [email protected]
950b8b0d37a9b7061b6f0d291837ccc4015f5ecd
)Steps to Reproduce:
echo "\a"
Assuming your OS is configured to allow TTY, you should hear a bell. In a normal terminal, this works fine. In code's, it does not.
Does this issue occur when all extensions are disabled?: Yes
The text was updated successfully, but these errors were encountered: