Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Status bar spinner is white in light themes and hard to see #45191

Closed
DanTup opened this issue Mar 7, 2018 · 2 comments · Fixed by #46083
Closed

Status bar spinner is white in light themes and hard to see #45191

DanTup opened this issue Mar 7, 2018 · 2 comments · Fixed by #46083
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug themes Color theme issues verified Verification succeeded
Milestone
March 2018

Comments

@DanTup
Copy link
Contributor

DanTup commented Mar 7, 2018

In light themes the status bar text changes from white to black, but progress spinners do not so they're hard to see:
@vscodebot vscodebot bot added the themes Color theme issues label Mar 7, 2018
@DanTup DanTup mentioned this issue Mar 7, 2018
Closed
@bpasero bpasero assigned jrieken and unassigned bpasero Mar 8, 2018
@bpasero
Copy link
Member

bpasero commented Mar 8, 2018 •
edited
Loading

This icon is probably not themable yet. E.g. for the status bar feedback smiley we use -webkit-mask trick to allow to change the color of it (refs).

Depending on the outcome of #44090 we might move this into the notification area though.

@jrieken jrieken added the feature-request Request for new features or functionality label Mar 8, 2018
@jrieken jrieken removed their assignment Mar 8, 2018
@bpasero bpasero self-assigned this Mar 17, 2018
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug and removed feature-request Request for new features or functionality labels Mar 17, 2018
bpasero added a commit that referenced this issue Mar 18, 2018
@bpasero
Status bar spinner is white in light themes and hard to see
21d3881 
fixes #45191
@bpasero bpasero mentioned this issue Mar 19, 2018
Merged
@bpasero
Copy link
Member

bpasero commented Mar 19, 2018

@jrieken fyi, the fix is to use a font for the icon (in this case our octicons). I found the sync icon fitting because we already use it for SCM sync:

before

Alternatively we could use this animation:

before

bpasero added a commit that referenced this issue Mar 19, 2018
@bpasero
Status bar spinner is white in light themes and hard to see (#46083)
9b25468 
fixes #45191
@bpasero bpasero added this to the March 2018 milestone Mar 19, 2018
@rebornix rebornix added the verified Verification succeeded label Mar 29, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug themes Color theme issues verified Verification succeeded
Projects
None yet
Milestone
March 2018
Development

Successfully merging a pull request may close this issue.

Status bar spinner is white in light themes and hard to see microsoft/vscode
4 participants
@rebornix @bpasero @DanTup @jrieken