Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG, CSS, Emmet] suggestion color if said "#" like "id".... #42245

Closed
ghost opened this issue Jan 27, 2018 · 3 comments
Closed

[BUG, CSS, Emmet] suggestion color if said "#" like "id".... #42245

ghost opened this issue Jan 27, 2018 · 3 comments
Assignees

Comments

@ghost
Copy link

ghost commented Jan 27, 2018

  • VSCode Version: Code 1.19.3 (7c4205b, 2018-01-25T10:36:34.867Z)
  • OS Version: Windows_NT x64 6.3.9600
  • Extensions:
Extension Author (truncated) Version
cpptools ms- 0.14.6

Steps to Reproduce:

  1. create CSS file
  2. write element#id, it will suggest colors.

screenshot_131
screenshot_132

Reproduces without extensions: Yes

@jens1o
Copy link
Contributor

jens1o commented Jan 27, 2018

cc @ramya-rao-a

@marcobeltempo
Copy link
Contributor

I am a new contributor to the vscode community and would like to take on this issue. I've reviewed the contributing guidelines and setup dev environment setup.

ramya-rao-a added a commit that referenced this issue Jan 28, 2018
@ramya-rao-a
Copy link
Contributor

Thanks for reporting @Mlocik97-issues!

The parser that we are using marks the node as a property instead of a rule. I have logged an upstream issue for that. emmetio/css-parser#3

I have made a short term fix via 7a50456 which will be available on Monday's Insiders build and in the next stable release of 1.20 which should be out in 2 weeks.

The right long term fix is to stop depending on the emmet's css parser and instead use our own from the css extension. This will be done as part of #29113.

@marcobeltempo Thanks for offering! There is quite some history around the code behind this issue which is going to change a lot with #29113, so I went ahead and fixed this myself.
I would suggest to look at any issues with labels help-wanted to get started with contributing to vscode

@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants