Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility: Support exposing current language to screen readers #3841

Closed
chrisdias opened this issue Mar 8, 2016 · 8 comments
Closed

Accessibility: Support exposing current language to screen readers #3841

chrisdias opened this issue Mar 8, 2016 · 8 comments
Assignees
@dbaeumer
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues important Issue identified as high-priority l10n-platform Localization platform issues (not wrong translations) verified Verification succeeded
Milestone
April 2016

Comments

@chrisdias
Copy link
Member

NVDA supports 43 languages, we should support exposing the current language to the tool.

Here is the requirement:

Ensure that user agents can correctly present content written in multiple languages. For all content, the default human language must be programmatically exposed when supported by the file format. Additionally, expose the language for each passage or phrase that differs from the default language. Exceptions include proper names, technical terms, and words or phrases that have been adopted into the default language.

CC: @zersiax
@chrisdias chrisdias added the accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues label Mar 8, 2016
@chrisdias chrisdias added this to the March 2016 milestone Mar 8, 2016
@zersiax
Copy link

zersiax commented Mar 8, 2016

Confirmed, this is a WCAG requirement. I'm not sure how Chromium renders the full VS Code interface, but in HTML this would be a matter of adding a proper lang attribute to the HTML element (usually a language is preferred rather than a language + dialect) for the entire document and lang attributes on the tags that deviate from the main language of the document.

@chrisdias chrisdias modified the milestones: Backlog, March 2016 Mar 8, 2016
@dbaeumer dbaeumer assigned alexdima and unassigned dbaeumer Mar 9, 2016
@dbaeumer
Copy link
Member

dbaeumer commented Mar 9, 2016

@alexandrudima do you have an idea how I can tell the screen reader the language of the UI? The language used to render the UI is available in process.env['VSCODE_NLS_CONFIG'].

@dbaeumer
Copy link
Member

dbaeumer commented Mar 9, 2016

@alexandrudima please move back if there is something I can do here.

@alexdima
Copy link
Member

@bpasero I think the problem is in electron-browser\index.html that hard-codes <html lang="en">. Not sure if this is something for March?

@alexdima alexdima assigned bpasero and unassigned alexdima Mar 17, 2016
@bpasero bpasero assigned dbaeumer and unassigned bpasero Mar 17, 2016
@bpasero
Copy link
Member

bpasero commented Mar 17, 2016

@dbaeumer if you feel brave, just make the change in index.html to pick up the language chosen. I have no clue what the implications are.

@dbaeumer dbaeumer modified the milestones: April 2016, Backlog Mar 17, 2016
@dbaeumer
Copy link
Member

@bpasero I will look into this for April. I am not brave enough to make this for March.

@bpasero
Copy link
Member

bpasero commented Mar 17, 2016

👍

@dbaeumer dbaeumer mentioned this issue Mar 21, 2016
Closed
@Tyriar
Copy link
Member

Tyriar commented Apr 14, 2016

Related: #4433 #5260

I marked them as important as it's mixing up characters for the various CJK languages.

@Tyriar Tyriar mentioned this issue Apr 15, 2016
Closed
@dbaeumer dbaeumer mentioned this issue Apr 18, 2016
Closed
@dbaeumer dbaeumer added l10n-platform Localization platform issues (not wrong translations) important Issue identified as high-priority labels Apr 18, 2016
bpasero added a commit that referenced this issue Apr 19, 2016
@bpasero
Merge pull request #5460 from Microsoft/dbaeumer/3841
2c14f73 
Fixes #3841: Accessibility: Support exposing current language to screen readers
@aeschli aeschli added the verified Verification succeeded label Apr 29, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dbaeumer dbaeumer

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues important Issue identified as high-priority l10n-platform Localization platform issues (not wrong translations) verified Verification succeeded
Projects
None yet
Milestone
April 2016
Development

No branches or pull requests
7 participants
@bpasero @chrisdias @dbaeumer @Tyriar @alexdima @zersiax @aeschli