Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saving an untitled file is not showing the prompt #35083

Closed
sandy081 opened this issue Sep 26, 2017 · 4 comments
Closed

Saving an untitled file is not showing the prompt #35083

sandy081 opened this issue Sep 26, 2017 · 4 comments
Assignees
@isidorn
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verified Verification succeeded
Milestone
September 2017

Comments

@sandy081
Copy link
Member

sandy081 commented Sep 26, 2017 •
edited
Loading

Testing #34696

  • Create a new Untitled file
  • Save the file. ( I used cmd+s)

No dialog appears
@vscodebot vscodebot bot added the workbench label Sep 26, 2017
@sandy081 sandy081 assigned bpasero and isidorn and unassigned sandy081 Sep 26, 2017
@sandy081 sandy081 added the important Issue identified as high-priority label Sep 26, 2017
@bpasero bpasero removed their assignment Sep 26, 2017
@bpasero
Copy link
Member

bpasero commented Sep 26, 2017 •
edited
Loading

@isidorn maybe a case of checking for IFileService.canHandleResource but not for untitled scheme? Maybe worth checking for other places where this could happen.

@isidorn isidorn added this to the September 2017 milestone Sep 26, 2017
@isidorn isidorn added the bug Issue identified by VS Code Team member as probable bug label Sep 26, 2017
@isidorn
Copy link
Contributor

isidorn commented Sep 26, 2017

@bpasero please code review. I checked all usages of canHandeResource in fileActions and added a check. If I have an untitileEditorService I use it to see if the resource is untitiled, otherwise I look at schema.

@bpasero
Copy link
Member

bpasero commented Sep 26, 2017

@isidorn I think you can just always do resource.scheme === 'untitled' that should be sufficient.

@isidorn
Copy link
Contributor

isidorn commented Sep 26, 2017

@bpasero thanks, I pushed

isidorn added a commit that referenced this issue Sep 26, 2017
@isidorn
just do schema === 'untitled'
45cbd76 
fixes #35083
@isidorn isidorn mentioned this issue Sep 27, 2017
Closed
@sandy081 sandy081 added the verified Verification succeeded label Sep 28, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verified Verification succeeded
Projects
None yet
Milestone
September 2017
Development

No branches or pull requests
3 participants
@bpasero @isidorn @sandy081