Provide way for a language to re-enable editor.quickSuggestions inside of a string or comment

[mjbvz]

Problem
Many languages allow embedding language fragments inside of strings. In JavaScript for example:

`Max int: ${Number.MAX_SAFE_INTEGER}`

While typing within the ${...} however, we do not show quick suggestions. The root cause is that the template expression is within a string, and the editor.quickSuggestion.strings setting explicitly disable quick suggestions within strings.

Proposal
We now have a convention of marking languages embedded within strings with the meta.embeded scope. This could be used to reset the quick suggestions scopes.

Here's the scope of the above code:

In this stack, we'd first see string.template which would disable quick suggestions. Then, further up the stack, we see meta.embedded which would reset the quick suggestion mode.

[mjbvz]

Actually that proposal may not work since we only enter the meta.embedded scope after the first character has been typed. We'd have to make sure quick suggestions checks the token type after the character is entered when it decided to trigger or not

Edit
Nevermind, I think #34863 is actually what was causing the odd behavior

[alexdima]

@mjbvz Not sure if this issue should be automatically closed. Leaving it up to you. The PR is in and published, and vscode-textmate updated in vscode.

[mjbvz]

Thanks @alexandrudima!

Yes there are still a few edge cases to handle still but the original issue has been addressed