Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - Async validation for ShowInputBox #34532

Closed
whiskeyjay opened this issue Sep 17, 2017 · 3 comments
Closed

Feature Request - Async validation for ShowInputBox #34532

whiskeyjay opened this issue Sep 17, 2017 · 3 comments
Assignees
Labels
api feature-request Request for new features or functionality quick-pick Quick-pick widget issues release-notes Release notes issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@whiskeyjay
Copy link

Scenario:

The Azure App Service Extension uses ShowInputBox to prompt user for the name of the new web app to be created. Then it checks the name availability by trying to resolve the DNS name of the web app. This operation can take up to a few seconds depending on network speed.

Currently the ShowInputBox doesn't seem to support async validation function, which means we can only validate after ShowInputBox function is done and re-prompt if the DNS value turns out not available.

The optimum experience: ShowInputBox supports async validation, when the validation function is running, the input box shows a progress indicator and won't allow the value be accepted (pressing Enter won't close the box), ESC should still cancel the input regardless.

@vscodebot vscodebot bot added the api label Sep 17, 2017
@jrieken jrieken added feature-request Request for new features or functionality quick-pick Quick-pick widget issues labels Sep 18, 2017
@jrieken
Copy link
Member

jrieken commented Sep 18, 2017

Understood. Technically it is already async but we wanted to enforce prompt and speedy validation because the user experience depends on this...

@chrisdias
Copy link
Member

@jrieken is this something you expect to support, and if so in Sept or later? thx.

@jrieken
Copy link
Member

jrieken commented Sep 19, 2017

We can support it, tho very unlikely in September

@jrieken jrieken added this to the October 2017 milestone Sep 22, 2017
@jrieken jrieken closed this as completed Oct 3, 2017
@jrieken jrieken added the verification-needed Verification of issue is requested label Oct 3, 2017
@roblourens roblourens added the verified Verification succeeded label Oct 31, 2017
@jrieken jrieken added the release-notes Release notes issues label Nov 3, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api feature-request Request for new features or functionality quick-pick Quick-pick widget issues release-notes Release notes issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants