Skip to content

Note sure what the following color keys do #25483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tyriar opened this issue Apr 26, 2017 · 1 comment
Closed

Note sure what the following color keys do #25483

Tyriar opened this issue Apr 26, 2017 · 1 comment
Assignees
Labels
themes Color theme issues
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Apr 26, 2017

#25328

  • VSCode Version: Code - Insiders 1.12.0-insider (48ae6e3, 2017-04-26T06:32:53.505Z)
  • OS Version: Linux x64 4.10.0-19-generic
  • Extensions:
Extension Author Version
EditorConfig EditorConfig 0.9.3
lorem-ipsum Tyriar 1.0.0
sort-lines Tyriar 1.2.0
theme-sapphire Tyriar 0.1.0
vscode-svgviewer cssho 1.4.0
tslint eg2 0.12.0
git-project-manager felipecaputo 1.3.2
md-navigate jrieken 0.0.1
vscode-scss mrmlnc 0.6.2
vetur octref 0.6.3
seti-icons qinjia 0.1.3

		"editorSideBySideBorder": "", // BinaryResourceDiffEditor...? This needs a better description
		"editorGroupBackground": "", // Not sure when this applies
		"statusBarInfoItemBackground": "", // ???
		"statusBarInfoItemHoverBackground": "", // ???
@bpasero bpasero added this to the April 2017 milestone Apr 27, 2017
@bpasero bpasero added themes Color theme issues workbench and removed workbench labels Apr 27, 2017
@bpasero
Copy link
Member

bpasero commented Apr 27, 2017

Pushed some updates:

  • editorMasterDetailsBorder: Border color to separate the details from the master side for side by side editors. Examples include diff editors and the settings editor.
  • editorGroupBackground: Background color of an editor group. Editor groups are the containers of editors. The background color shows up when dragging editor groups around.
  • statusBarProminentItemBackground: Status bar prominent items background color. Prominent items stand out from other status bar entries to indicate importance. The status bar is shown in the bottom of the window.
  • statusBarProminentItemHoverBackground: Status bar prominent items background color when hovering. Prominent items stand out from other status bar entries to indicate importance. The status bar is shown in the bottom of the window.

@bpasero bpasero closed this as completed Apr 27, 2017
bpasero added a commit that referenced this issue Apr 27, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
themes Color theme issues
Projects
None yet
Development

No branches or pull requests

2 participants