Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider to use dots instead of camel-case #25428

Closed
jrieken opened this issue Apr 26, 2017 · 16 comments
Closed

Consider to use dots instead of camel-case #25428

jrieken opened this issue Apr 26, 2017 · 16 comments
Assignees
Labels
themes Color theme issues under-discussion Issue is under discussion for relevance, priority, approach
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented Apr 26, 2017

re #25328

The theme-color-names use camel-casing, like inactiveTabInactiveGroupForeground, which is weird because in settings et al we use dot-separation, like workbench.editor.showTabs.

@jrieken
Copy link
Member Author

jrieken commented Apr 26, 2017

cc @Microsoft/vscode

@bpasero
Copy link
Member

bpasero commented Apr 26, 2017

What I don't like about the dot notation is that it makes the color arbritrarly longer, for example inactiveTabInactiveGroupForeground would probably turn into workbench.editor.tabs.group.inactive.foreground or are you suggesting inactive.tab.inactive.group.foreground?

@bpasero bpasero added this to the April 2017 milestone Apr 26, 2017
@bpasero bpasero added the under-discussion Issue is under discussion for relevance, priority, approach label Apr 26, 2017
@jrieken
Copy link
Member Author

jrieken commented Apr 26, 2017

Yeah, not suggesting to use config-names but their separation style. With inactiveTabInactiveGroupForeground I might have chosen a bad sample but I would prefer activityBar.background over activityBarBackground

@bpasero
Copy link
Member

bpasero commented Apr 26, 2017

Works for me if we find short names. I am not attached to camel case.

@bpasero bpasero added the themes Color theme issues label Apr 26, 2017
@Tyriar
Copy link
Member

Tyriar commented Apr 26, 2017

👍 This is how we do namespaces in our top-level settings

@Tyriar
Copy link
Member

Tyriar commented Apr 26, 2017

It would also force better naming for things like this:

		// Workbench: Tabs
		"tabsContainerBackground": "",
		"tabBorder": "",
		"activeTabBackground": "",
		"inactiveTabBackground": "",
		"activeTabActiveGroupForeground": "",
		"activeTabInactiveGroupForeground": "",
		"inactiveTabActiveGroupForeground": "",
		"inactiveTabInactiveGroupForeground": "",

@cleidigh
Copy link
Contributor

can I vote to give different buttons button groups even if we don't have them all themable yet (extension install etc)

eg
notification.button.background
sidebar.button.foreground
editor..button.foreground

etc

@bpasero
Copy link
Member

bpasero commented Apr 28, 2017

Here is my proposal (left hand side is the new color key and right hand side is the old one):

Rules:

// 	Pattern: <category?>.<name?>.<state?>.<type>
// 		<category>: optional, anything like editor
//		<name>: 	optional, anything like findWidget
//		<state>: 	optional, something like hover, active, selection, focus
// 		<type>: 	something like border, foreground, background, shadow

Result:

{
	// Base
	"foreground": "",
	"focus.border": "focusBorder",
	"contrast.border": "contrastBorder",
	"contrast.active.border": "activeContrastBorder",

	"widget.shadow": "widgetShadow",

	"input.background": "inputBoxBackground",
	"input.border": "inputBoxBorder",
	"input.foreground": "inputBoxForeground",
	"input.option.active.border": "inputBoxActiveOptionBorder",
	"input.validation.info.background": "inputValidationInfoBackground",
	"input.validation.info.border": "inputValidationInfoBorder",
	"input.validation.warning.background": "inputValidationWarningBackground",
	"input.validation.warning.border": "inputValidationWarningBorder",
	"input.validation.error.background": "inputValidationErrorBackground",
	"input.validation.error.border": "inputValidationErrorBorder",

	"dropdown.background": "dropdownBackground",
	"dropdown.foreground": "dropdownForeground",
	"dropdown.border": "dropdownBorder",

	"button.background": "buttonBackground",
	"button.hover.background": "buttonHoverBackground",
	"button.foreground": "buttonForeground",

	"list.activeSelection.background": "listActiveSelectionBackground",
	"list.activeSelection.foreground": "listActiveSelectionForeground",
	"list.inactiveSelection.background": "listInactiveSelectionBackground",
	"list.focusAndSelection.background": "listFocusAndSelectionBackground",
	"list.focusAndSelection.foreground": "listFocusAndSelectionForeground",
	"list.focus.background": "listFocusBackground",
	"list.hover.background": "listHoverBackground",
	"list.highlight.foreground": "listHighlightForeground",
	"list.drop.background": "listDropBackground",

	"scrollbar.shadow": "scrollbarShadow",
	"scrollbar.slider.background": "scrollbarSliderBackground",
	"scrollbar.slider.active.background": "scrollbarSliderActiveBackground",
	"scrollbar.slider.hover.background": "scrollbarSliderHoverBackground",

	// Editor
	"editor.background": "editorBackground",
	"editor.foreground": "editorForeground",
	"editor.widget.background": "editorWidgetBackground",
	"editor.cursor.foreground": "editorCursor",
	"editor.whitespace.foreground": "editorWhitespaces",
	"editor.lineHighlight.background": "editorLineHighlight",
	"editor.selection.background": "editorSelection",
	"editor.indentGuide.background": "editorIndentGuides",
	"editor.hoverWidget.background": "editorHoverBackground",
	"editor.hoverWidget.border": "editorHoverBorder",
	"editor.lineNumber.foreground": "editorLineNumbers",
	"editor.markerNavigation.background": "editorMarkerNavigationBackground",
	"editor.markerNavigationError.background": "editorMarkerNavigationError",
	"editor.markerNavigationWarning.background": "editorMarkerNavigationWarning",
	"editor.link.foreground": "editorLinkForeground",
	"editor.link.active.foreground": "editorActiveLinkForeground",
	"editor.findMatch.background": "editorFindMatch",
	"editor.findMatchHighlight.background": "editorFindMatchHighlight",
	"editor.findRangeHighlight.background": "editorFindRangeHighlight",
	"editor.hoverHighlight.background": "editorHoverHighlight",
	"editor.inactiveSelection.background": "editorInactiveSelection",
	"editor.lineHighlight.border": "editorLineHighlightBorder",
	"editor.rangeHighlight.background": "editorRangeHighlight",
	"editor.selectionHighlight.background": "editorSelectionHighlight",
	"editor.suggestMatchHighlight.foreground": "editorSuggestMatchHighlight",
	"editor.suggestWidget.background": "editorSuggestWidgetBackground",
	"editor.suggestWidget.border": "editorSuggestWidgetBorder",
	"editor.suggestWidget.foreground": "editorSuggestWidgetForeground",
	"editor.suggestWidget.selected.background": "editorSuggestWidgetSelectedBackground",
	"editor.suggestWidget.highlight.foreground": "editorSuggestWidgetHighlightForeground",
	"editor.wordHighlight.background": "editorWordHighlight",
	"editor.wordHighlight.strong.background": "editorWordHighlightStrong",

	// Editor: Peek View
	"peekView.results.background": "peekViewResultsBackground",
	"peekView.resultMatch.foreground": "peekViewResultsMatchForeground",
	"peekView.resultSelection.background": "peekViewResultsSelectionBackground",
	"peekView.resultSelection.foreground": "peekViewResultsSelectionForeground",
	"peekView.editor.background": "peekViewEditorBackground",
	"peekView.title.background": "peekViewTitleBackground",
	"peekView.border": "peekViewBorder",
	"peekView.editorMatchHighlight.background": "peekViewEditorMatchHighlight",
	"peekView.resultMatchHighlight.background": "peekViewResultsMatchHighlight",
	"peekView.fileResult.foreground": "peekViewResultsFileForeground",
	"peekView.title.foreground": "peekViewTitleForeground",
	"peekView.titleInfo.foreground": "peekViewTitleInfoForeground",

	// Editor: Diff
	"diffEditor.inserted.background": "diffEditorInserted",
	"diffEditor.inserted.border": "diffEditorInsertedOutline",
	"diffEditor.removed.background": "diffEditorRemoved",
	"diffEditor.removed.border": "diffEditorRemovedOutline",

	// Editor: Master / Details
	"masterDetailsEditor.border": "editorMasterDetailsBorder",

	// Workbench: Title
	"titleBar.active.background": "titleBarActiveBackground",
	"titleBar.active.foreground": "titleBarActiveForeground",
	"titleBar.inactive.background": "titleBarInactiveBackground",
	"titleBar.inactive.foreground": "titleBarInactiveForeground",

	// Workbench: Editors
	"editorGroup.background": "editorGroupBackground",
	"editorGroup.header.tabs.background": "tabsContainerBackground",
	"editorGroup.header.noTabs.background": "editorGroupHeaderBackground",
	"editorGroup.border": "editorGroupBorder",
	"editorGroup.drop.background": "editorDragAndDropBackground",

	// Workbench: Tabs
	"tab.border": "tabBorder",
	"tab.active.background": "tabActiveBackground",
	"tab.inactive.background": "tabInactiveBackground",
	"tab.active.foreground": "tabActiveEditorGroupActiveForeground",
	"tab.inactive.foreground": "tabInactiveEditorGroupActiveForeground",
	"tab.active.inactiveEditorGroup.foreground": "tabActiveEditorGroupInactiveForeground",
	"tab.inactive.inactiveEditorGroup.foreground": "tabInactiveEditorGroupInactiveForeground",

	// Workbench: Activity Bar
	"activityBar.background": "activityBarBackground",
	"activityBar.foreground": "activityBarForeground",
	"activityBar.drop.background": "activityBarDragAndDropBackground",
	"activityBar.badge.background": "activityBarBadgeBackground",
	"activityBar.badge.foreground": "activityBarBadgeForeground",

	// Workbench: Panel
	"panel.background": "panelBackground",
	"panel.border": "panelBorder",
	"panel.title.active.border": "panelActiveTitleBorder",
	"panel.title.active.foreground": "panelActiveTitleForeground",
	"panel.title.inactive.foreground": "panelInactiveTitleForeground",

	// Workbench: Side Bar
	"sideBar.background": "sideBarBackground",
	"sideBar.title.foreground": "sideBarTitleForeground",
	"sideBar.sectionHeader.background": "sideBarSectionHeaderBackground",

	// Workbench: Status Bar
	"statusBar.background": "statusBarBackground",
	"statusBar.noFolder.background": "statusBarNoFolderBackground",
	"statusBar.debugging.background": "statusBarDebuggingBackground",
	"statusBar.foreground": "statusBarForeground",
	"statusBar.item.hover.background": "statusBarItemHoverBackground",
	"statusBar.item.active.background": "statusBarItemActiveBackground",
	"statusBar.prominentItem.background": "statusBarProminentItemBackground",
	"statusBar.prominentItem.hover.background": "statusBarProminentItemHoverBackground",

	// Workbench: Debug
	"debug.toolBar.background": "debugToolBarBackground",
	"debug.exceptionWidget.background": "debugExceptionWidgetBackground",
	"debug.exceptionWidget.border": "debugExceptionWidgetBorder",

	// Workbench: Notifications
	"notification.background": "notificationsBackground",
	"notification.foreground": "notificationsForeground",

	// Workbench: Quick Open
	"picker.group.border": "pickerGroupBorder",
	"picker.group.foreground": "pickerGroupForeground",

	// Workbench: Terminal
	"terminal.ansi.black": "terminalAnsiBlack",
	"terminal.ansi.blue": "terminalAnsiBlue",
	"terminal.ansi.brightBlack": "terminalAnsiBrightBlack",
	"terminal.ansi.brightBlue": "terminalAnsiBrightBlue",
	"terminal.ansi.brightCyan": "terminalAnsiBrightCyan",
	"terminal.ansi.brightGreen": "terminalAnsiBrightGreen",
	"terminal.ansi.brightMagenta": "terminalAnsiBrightMagenta",
	"terminal.ansi.brightRed": "terminalAnsiBrightRed",
	"terminal.ansi.brightWhite": "terminalAnsiBrightWhite",
	"terminal.ansi.brightYellow": "terminalAnsiBrightYellow",
	"terminal.ansi.cyan": "terminalAnsiCyan",
	"terminal.ansi.green": "terminalAnsiGreen",
	"terminal.ansi.magenta": "terminalAnsiMagenta",
	"terminal.ansi.red": "terminalAnsiRed",
	"terminal.ansi.white": "terminalAnsiWhite",
	"terminal.ansi.yellow": "terminalAnsiYellow"
}

@Microsoft/vscode feedback welcome

@mjbvz
Copy link
Collaborator

mjbvz commented Apr 28, 2017

@bpasero I'm a fan of the proposal. It makes the names more readable and consistent, and gives us a clear pattern to follow for any future theming points

@cleidigh
Copy link
Contributor

@bpasero
I like it
in the next round you could add

extension.install.button.foreground

and I think this would be consistent and not break anything that just used
button.foreground

@aeschli
Copy link
Contributor

aeschli commented Apr 28, 2017

Here's my variant. One less dot as it uses dots only for separating UI elements.

{
	// Base
	"foreground": "",
	"focusBorder": "focusBorder",
	"contrastBorder": "contrastBorder",
	"contrastActiveBorder": "activeContrastBorder",

	"widget.shadow": "widgetShadow",

	"input.background": "inputBoxBackground",
	"input.border": "inputBoxBorder",
	"input.foreground": "inputBoxForeground",
	"input.option.activeBorder": "inputBoxActiveOptionBorder",
	"input.validation.infoBackground": "inputValidationInfoBackground",
	"input.validation.infoBorder": "inputValidationInfoBorder",
	"input.validation.warningBackground": "inputValidationWarningBackground",
	"input.validation.warningBorder": "inputValidationWarningBorder",
	"input.validation.errorBackground": "inputValidationErrorBackground",
	"input.validation.errorBorder": "inputValidationErrorBorder",

	"dropdown.background": "dropdownBackground",
	"dropdown.foreground": "dropdownForeground",
	"dropdown.border": "dropdownBorder",

	"button.background": "buttonBackground",
	"button.hoverBackground": "buttonHoverBackground",
	"button.foreground": "buttonForeground",

	"list.activeSelectionBackground": "listActiveSelectionBackground",
	"list.activeSelectionForeground": "listActiveSelectionForeground",
	"list.inactiveSelectionBackground": "listInactiveSelectionBackground",
	"list.focusAndSelectionBackground": "listFocusAndSelectionBackground",
	"list.focusAndSelectionForeground": "listFocusAndSelectionForeground",
	"list.focusBackground": "listFocusBackground",
	"list.hoverBackground": "listHoverBackground",
	"list.highlightForeground": "listHighlightForeground",
	"list.dropBackground": "listDropBackground",

	"scrollbar.shadow": "scrollbarShadow",
	"scrollbar.slider.background": "scrollbarSliderBackground",
	"scrollbar.slider.activeBackground": "scrollbarSliderActiveBackground",
	"scrollbar.slider.hoverBackground": "scrollbarSliderHoverBackground",

	// Editor
	"editor.background": "editorBackground",
	"editor.foreground": "editorForeground",
	"editor.widget.background": "editorWidgetBackground",
	"editor.cursor.foreground": "editorCursor",
	"editor.whitespace.foreground": "editorWhitespaces",
	"editor.lineHighlight.background": "editorLineHighlight",
	"editor.selection.background": "editorSelection",
	"editor.indentGuide.background": "editorIndentGuides",
	"editor.hoverWidget.background": "editorHoverBackground",
	"editor.hoverWidget.border": "editorHoverBorder",
	"editor.lineNumber.foreground": "editorLineNumbers",
	"editor.markerNavigation.background": "editorMarkerNavigationBackground",
	"editor.markerNavigationError.background": "editorMarkerNavigationError",
	"editor.markerNavigationWarning.background": "editorMarkerNavigationWarning",
	"editor.link.foreground": "editorLinkForeground",
	"editor.link.activeForeground": "editorActiveLinkForeground",
	"editor.findMatch.background": "editorFindMatch",
	"editor.findMatchHighlight.background": "editorFindMatchHighlight",
	"editor.findRangeHighlight.background": "editorFindRangeHighlight",
	"editor.hoverHighlight.background": "editorHoverHighlight",
	"editor.inactiveSelection.background": "editorInactiveSelection",
	"editor.lineHighlight.border": "editorLineHighlightBorder",
	"editor.rangeHighlight.background": "editorRangeHighlight",
	"editor.selectionHighlight.background": "editorSelectionHighlight",
	"editor.suggestMatchHighlight.foreground": "editorSuggestMatchHighlight",
	"editor.suggestWidget.background": "editorSuggestWidgetBackground",
	"editor.suggestWidget.border": "editorSuggestWidgetBorder",
	"editor.suggestWidget.foreground": "editorSuggestWidgetForeground",
	"editor.suggestWidget.selectedBackground": "editorSuggestWidgetSelectedBackground",
	"editor.suggestWidget.highlightForeground": "editorSuggestWidgetHighlightForeground",
	"editor.wordHighlight.background": "editorWordHighlight",
	"editor.wordHighlight.strong.background": "editorWordHighlightStrong",

	// Editor: Peek View
	"peekView.result.background": "peekViewResultsBackground",
	"peekView.result.itemForeground": "peekViewResultsMatchForeground",
	"peekView.result.containerForeground": "peekViewResultsFileForeground",
	"peekView.result.selectionBackground": "peekViewResultsSelectionBackground",
	"peekView.result.selectionForeground": "peekViewResultsSelectionForeground",
	"peekView.result.matchHighlightBackground": "peekViewResultsMatchHighlight",

	"peekView.title.background": "peekViewTitleBackground",
	"peekView.border": "peekViewBorder",
	"peekView.editor.background": "peekViewEditorBackground",
	"peekView.editor.matchHighlight.background": "peekViewEditorMatchHighlight",

	"peekView.title.foreground": "peekViewTitleForeground",
	"peekView.titleInfo.foreground": "peekViewTitleInfoForeground",

	// Editor: Diff
	"diffEditor.insertedText.background": "diffEditorInserted",
	"diffEditor.insertedText.border": "diffEditorInsertedOutline",
	"diffEditor.removedText.background": "diffEditorRemoved",
	"diffEditor.removedText.border": "diffEditorRemovedOutline",

	// Editor: Master / Details
	"masterDetailsEditor.border": "editorMasterDetailsBorder",

	// Workbench: Title
	"titleBar.activeBackground": "titleBarActiveBackground",
	"titleBar.activeForeground": "titleBarActiveForeground",
	"titleBar.inactiveBackground": "titleBarInactiveBackground",
	"titleBar.inactiveForeground": "titleBarInactiveForeground",

	// Workbench: Editors
	"editorGroup.background": "editorGroupBackground",
	"editorGroup.header.tabs.background": "tabsContainerBackground",
	"editorGroup.header.noTabs.background": "editorGroupHeaderBackground",
	"editorGroup.border": "editorGroupBorder",
	"editorGroup.drop.background": "editorDragAndDropBackground",

	// Workbench: Tabs
	"tab.border": "tabBorder",
	"tab.active.background": "tabActiveBackground",
	"tab.inactive.background": "tabInactiveBackground",
	"tab.active.foreground": "tabActiveEditorGroupActiveForeground",
	"tab.inactive.foreground": "tabInactiveEditorGroupActiveForeground",
	"tab.active.inactiveEditorGroup.foreground": "tabActiveEditorGroupInactiveForeground",
	"tab.inactive.inactiveEditorGroup.foreground": "tabInactiveEditorGroupInactiveForeground",

	// Workbench: Activity Bar
	"activityBar.background": "activityBarBackground",
	"activityBar.foreground": "activityBarForeground",
	"activityBar.dropBackground": "activityBarDragAndDropBackground",
	"activityBar.badge.background": "activityBarBadgeBackground",
	"activityBar.badge.foreground": "activityBarBadgeForeground",

	// Workbench: Panel
	"panel.background": "panelBackground",
	"panel.border": "panelBorder",
	"panel.title.activeBorder": "panelActiveTitleBorder",
	"panel.title.activeForeground": "panelActiveTitleForeground",
	"panel.title.inactiveForeground": "panelInactiveTitleForeground",

	// Workbench: Side Bar
	"sideBar.background": "sideBarBackground",
	"sideBar.title.foreground": "sideBarTitleForeground",
	"sideBar.sectionHeader.background": "sideBarSectionHeaderBackground",

	// Workbench: Status Bar
	"statusBar.background": "statusBarBackground",
	"statusBar.noFolder.background": "statusBarNoFolderBackground",
	"statusBar.debugging.background": "statusBarDebuggingBackground",
	"statusBar.foreground": "statusBarForeground",
	"statusBar.item.hoverBackground": "statusBarItemHoverBackground",
	"statusBar.item.activeBackground": "statusBarItemActiveBackground",
	"statusBar.prominentItem.background": "statusBarProminentItemBackground",
	"statusBar.prominentItem.hoverBackground": "statusBarProminentItemHoverBackground",

	// Workbench: Debug
	"debug.toolBar.background": "debugToolBarBackground",
	"debug.exceptionWidget.background": "debugExceptionWidgetBackground",
	"debug.exceptionWidget.border": "debugExceptionWidgetBorder",

	// Workbench: Notifications
	"notification.background": "notificationsBackground",
	"notification.foreground": "notificationsForeground",

	// Workbench: Quick Open
	"picker.group.border": "pickerGroupBorder",
	"picker.group.foreground": "pickerGroupForeground",

	// Workbench: Terminal
	"terminal.ansi.black": "terminalAnsiBlack",
	"terminal.ansi.blue": "terminalAnsiBlue",
	"terminal.ansi.brightBlack": "terminalAnsiBrightBlack",
	"terminal.ansi.brightBlue": "terminalAnsiBrightBlue",
	"terminal.ansi.brightCyan": "terminalAnsiBrightCyan",
	"terminal.ansi.brightGreen": "terminalAnsiBrightGreen",
	"terminal.ansi.brightMagenta": "terminalAnsiBrightMagenta",
	"terminal.ansi.brightRed": "terminalAnsiBrightRed",
	"terminal.ansi.brightWhite": "terminalAnsiBrightWhite",
	"terminal.ansi.brightYellow": "terminalAnsiBrightYellow",
	"terminal.ansi.cyan": "terminalAnsiCyan",
	"terminal.ansi.green": "terminalAnsiGreen",
	"terminal.ansi.magenta": "terminalAnsiMagenta",
	"terminal.ansi.red": "terminalAnsiRed",
	"terminal.ansi.white": "terminalAnsiWhite",
	"terminal.ansi.yellow": "terminalAnsiYellow"
}

@cleidigh
Copy link
Contributor

cleidigh commented Apr 28, 2017

@aeschli
having the type separated by. Also could allow group functionality and association more easily IMHO

... and periods are pretty cheap ;-)

@dbaeumer
Copy link
Member

Looking at both @bpasero and @aeschli proposal the one from @bpasero is easier to read and understand for me.

@bpasero
Copy link
Member

bpasero commented Apr 28, 2017

We settled on the following:

{
        // --- base
        "foreground": "",
        "focusBorder": "",
        "contrastBorder": "",
        "contrastActiveBorder": "",

        "widget.shadow": "",

        "input.background": "",
        "input.foreground": "",
        "input.border": "",

        "inputOption.activeBorder": "",

        "inputValidation.infoBackground": "",
        "inputValidation.infoBorder": "",
        "inputValidation.warningBackground": "",
        "inputValidation.warningBorder": "",
        "inputValidation.errorBackground": "",
        "inputValidation.errorBorder": "",

        "dropdown.background": "",
        "dropdown.foreground": "",
        "dropdown.border": "",

        "list.focusAndSelectionBackground": "",
        "list.focusAndSelectionForeground": "",
        "list.activeSelectionBackground": "",
        "list.activeSelectionForeground": "",
        "list.inactiveSelectionBackground": "",
        "list.focusBackground": "",
        "list.hoverBackground": "",
        "list.dropBackground": "",
        "list.highlightForeground": "",

        "pickerGroup.foreground": "",
        "pickerGroup.border": "",

        "button.foreground": "",
        "button.background": "",
        "button.hoverBackground": "",

        "scrollbar.shadow": "",
        "scrollbarSlider.background": "",
        "scrollbarSlider.hoverBackground": "",
        "scrollbarSlider.activeBackground": "",

        // --- editor
        "editor.background": "",
        "editor.foreground": "",
        "editor.selectionBackground": "",
        "editor.inactiveSelectionBackground": "",
        "editor.selectionHighlightBackground": "",
        "editor.findMatchBackground": "",
        "editor.findMatchHighlightBackground": "",
        "editor.findRangeHighlightBackground": "",
        "editorLink.activeForeground": "",
        "editorLink.foreground": "",
        "editorWidget.background": "",
        "editor.lineHighlightBackground": "",
        "editor.lineHighlightBorder": "",
        "editor.rangeHighlightBackground": "",
        "editor.wordHighlightBackground": "",
        "editor.wordHighlightStrongBackground": "",
        "editorCursor.foreground": "",
        "editorWhitespace.foreground": "",
        "editorIndentGuide.background": "",
        "editorLineNumber.foreground": "",
        "editorMarkerNavigationError.background": "",
        "editorMarkerNavigationWarning.background": "",
        "editorMarkerNavigation.background": "",
        "editor.hoverHighlightBackground": "",
        "editorHoverWidget.background": "",
        "editorHoverWidget.border": "",

        // --- editor suggest
        "editorSuggestWidget.background": "",
        "editorSuggestWidget.border": "",
        "editorSuggestWidget.foreground": "",
        "editorSuggestWidget.selectedBackground": "",
        "editorSuggestWidget.highlightForeground": "",

        // --- peek view editor
        "peekView.border": "",
	"peekViewEditor.background": "",
        "peekViewEditor.matchHighlightBackground": "",
        "peekViewTitle.background": "",
        "peekViewTitleLabel.foreground": "",
        "peekViewTitleDescription.foreground": "",
        "peekViewResult.background": "",
        "peekViewResult.selectionBackground": "",
        "peekViewResult.selectionForeground": "",
        "peekViewResult.matchHighlightBackground": "",
        "peekViewResult.fileForeground": "",
        "peekViewResult.lineForeground": "",

        // --- diff editor
        "diffEditor.insertedTextBackground": "",
        "diffEditor.removedTextBackground": "",
        "diffEditor.insertedTextBorder": "",
        "diffEditor.removedTextBorder": "",

        // --- workbench: editor group
        "editorGroup.background": "",
        "editorGroup.border": "",
        "editorGroup.dropBackground": "",
        "editorGroupHeader.tabsBackground": "",
        "editorGroupHeader.noTabsBackground": "",

        // --- workbench: tabs
        "tab.activeBackground": "",
        "tab.inactiveBackground": "",
        "tab.activeForeground": "",
        "tab.inactiveForeground": "",
        "tab.border": "",

        // --- workbench: panel
        "panel.background": "",
        "panel.border": "",
        "panelTitle.activeForeground": "",
        "panelTitle.inactiveForeground": "",
        "panelTitle.activeBorder": "",

        // --- workbench: status bar
        "statusBar.foreground": "",
        "statusBar.background": "",
        "statusBar.noFolderBackground": "",
        "statusBar.debuggingBackground": "",
        "statusBarItem.activeBackground": "",
        "statusBarItem.hoverBackground": "",
        "statusBarItem.prominentBackground": "",
        "statusBarItem.prominentHoverBackground": "",

        // --- workbench: activity bar
        "activityBar.background": "",
        "activityBar.foreground": "",
        "activityBar.dropBackground": "",
        "activityBarBadge.background": "",
        "activityBarBadge.foreground": "",

        // --- workbench: side bar
        "sideBar.background": "",
        "sideBarTitle.foreground": "",
        "sideBarSectionHeader.background": "",

        // --- workbench: title bar
        "titleBar.activeForeground": "",
        "titleBar.inactiveForeground": "",
        "titleBar.activeBackground": "",
        "titleBar.inactiveBackground": "",

        // --- workbench: notifications
        "notification.foreground": "",
        "notification.background": "",
        
        // --- workbench: debug
        "debugExceptionWidget.border": "",
        "debugExceptionWidget.background": "",
        "debugToolBar.background": "",

        // --- workbench: terminal
        "terminal.ansiBlack": "",
        "terminal.ansiRed": "",
        "terminal.ansiGreen": "",
        "terminal.ansiYellow": "",
        "terminal.ansiBlue": "",
        "terminal.ansiMagenta": "",
        "terminal.ansiCyan": "",
        "terminal.ansiWhite": "",
        "terminal.ansiBrightBlack": "",
        "terminal.ansiBrightRed": "",
        "terminal.ansiBrightGreen": "",
        "terminal.ansiBrightYellow": "",
        "terminal.ansiBrightBlue": "",
        "terminal.ansiBrightMagenta": "",
        "terminal.ansiBrightCyan": "",
        "terminal.ansiBrightWhite": ""
}

@schmuli
Copy link

schmuli commented May 1, 2017

@bpasero Would it be possible to update your last comment with the mapping to the old keys, as some of them have changed more than just a '.' in between?

@bpasero
Copy link
Member

bpasero commented May 1, 2017

@schmuli no, but this information can be found here and here

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
themes Color theme issues under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

8 participants