Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When typing a longer comment, the buttons scroll out of view #239578

Closed
alexdima opened this issue Feb 4, 2025 · 1 comment · Fixed by #239672
Closed

When typing a longer comment, the buttons scroll out of view #239578

alexdima opened this issue Feb 4, 2025 · 1 comment · Fixed by #239672
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release regression Something that used to work is now broken verified Verification succeeded
Milestone
January 2025

Comments

@alexdima
Copy link
Member

alexdima commented Feb 4, 2025

  • Write a longer comment
  • The input area grows, but I cannot scroll to the buttons
CleanShot.2025-02-04.at.10.35.35.mp4 
Version: 1.97.0-insider
Commit: e72728b5e8fd701287d993699f2f667a2dcad3f3
Date: 2025-02-03T22:42:32.123Z
Electron: 32.2.7
ElectronBuildId: 10660205
Chromium: 128.0.6613.186
Node.js: 20.18.1
V8: 12.8.374.38-electron.0
OS: Darwin arm64 24.3.0
@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release labels Feb 4, 2025
@alexr00 alexr00 added this to the January 2025 milestone Feb 4, 2025
@alexr00
Copy link
Member

alexr00 commented Feb 4, 2025

Broken by #236763

alexr00 added a commit that referenced this issue Feb 4, 2025
@alexr00
When typing a longer comment, the buttons scroll out of view
7f44746 
Part of #239578
@alexr00 alexr00 mentioned this issue Feb 4, 2025
Merged
alexr00 added a commit that referenced this issue Feb 4, 2025
@alexr00
When typing a longer comment, the buttons scroll out of view
1d71ab3 
Part of #239578
@alexr00 alexr00 mentioned this issue Feb 4, 2025
Merged
alexr00 added a commit that referenced this issue Feb 4, 2025
@alexr00
When typing a longer comment, the buttons scroll out of view (#239587)
a045859 
Part of #239578
connor4312 pushed a commit that referenced this issue Feb 4, 2025
@alexr00
When typing a longer comment, the buttons scroll out of view (#239589)
33fc5a9 
* When typing a longer comment, the buttons scroll out of view
Part of #239578

* Switch to opt in
@dbaeumer dbaeumer added the regression Something that used to work is now broken label Feb 5, 2025
@alexr00 alexr00 closed this as completed Feb 5, 2025
alexr00 added a commit that referenced this issue Feb 5, 2025
@alexr00
Flip the zone widget noMax to be useMax (opt in)
07c75bf 
Per the candidate fix in #239589
Fixes #239578
@alexr00 alexr00 mentioned this issue Feb 5, 2025
Merged
alexr00 added a commit that referenced this issue Feb 5, 2025
@alexr00
Flip the zone widget noMax to be useMax (opt in) (#239672)
0185e3b 
Per the candidate fix in #239589
Fixes #239578
@alexdima alexdima added the verified Verification succeeded label Feb 5, 2025
@alexr00 alexr00 mentioned this issue Feb 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release regression Something that used to work is now broken verified Verification succeeded
Projects
None yet
Milestone
January 2025
Development

Successfully merging a pull request may close this issue.

Flip the zone widget noMax to be useMax (opt in) microsoft/vscode
3 participants
@dbaeumer @alexdima @alexr00