Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ExcludeSettingOptions comments #223387

Closed
Tyriar opened this issue Jul 23, 2024 · 2 comments · Fixed by #223950
Closed

Improve ExcludeSettingOptions comments #223387

Tyriar opened this issue Jul 23, 2024 · 2 comments · Fixed by #223950
Assignees
Labels
insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue search Search widget and operation issues search-api
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Jul 23, 2024

Testing #223154

These would be better formed as a sentence imo:

/*
* Use:
* - files.exclude setting
*/
filesExclude = 2,
/*
* Use:
* - files.exclude setting
* - search.exclude setting
*/
searchAndFilesExclude = 3

Current (if I add the /**):

Screenshot 2024-07-23 at 2 04 54 PM

Proposal something like:

Screenshot 2024-07-23 at 2 05 51 PM
@andreamah andreamah added search Search widget and operation issues polish Cleanup and polish issue search-api labels Jul 24, 2024
@andreamah andreamah added this to the August 2024 milestone Jul 24, 2024
andreamah added a commit that referenced this issue Jul 26, 2024
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Jul 26, 2024
Copy link

Issue marked as unreleased but unable to locate closing commit in repo history. If this was closed in a separate repo you can add the insiders-released label directly, or comment \closedWith someShaThatWillbeReleasedWhenThisIsRelesed.

@vs-code-engineering vs-code-engineering bot removed the unreleased Patch has not yet been released in VS Code Insiders label Jul 31, 2024
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Jul 31, 2024
Copy link

		Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting `\closedWith someCommitSha`, or directly add the `insiders-released` label if you know this has already been releaased

@vs-code-engineering vs-code-engineering bot added unreleased Patch has not yet been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 31, 2024
@vs-code-engineering vs-code-engineering bot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 24, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue search Search widget and operation issues search-api
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants