Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor Placeholder Support #208976

Closed
hediet opened this issue Mar 28, 2024 · 4 comments · Fixed by #210939
Closed

Editor Placeholder Support #208976

hediet opened this issue Mar 28, 2024 · 4 comments · Fixed by #210939
Assignees
Labels
editor-core Editor basic functionality feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@hediet
Copy link
Member

hediet commented Mar 28, 2024

@roblourens To verify, go to the VS sources and run:

PlaceholderTextContribution.get(editor).setPlaceholderText('myPlaceholder')
@hediet hediet added feature-request Request for new features or functionality editor-core Editor basic functionality labels Mar 28, 2024
@hediet hediet added this to the April 2024 milestone Mar 28, 2024
@hediet hediet self-assigned this Mar 28, 2024
hediet added a commit that referenced this issue Apr 22, 2024
hediet added a commit that referenced this issue Apr 22, 2024
@hediet hediet added the verification-needed Verification of issue is requested label Apr 22, 2024
hediet added a commit that referenced this issue Apr 22, 2024
sergioengineer pushed a commit to sergioengineer/VimSCode that referenced this issue Apr 23, 2024
@deepak1556
Copy link
Collaborator

Closing for verification.

@aiday-mar aiday-mar added the verified Verification succeeded label Apr 24, 2024
@roblourens
Copy link
Member

I'm able to use this when the input box is empty, and it works great, thanks! But when there is an @ participant in the input, I still use a text decoration to show the participant description after the name. This is fine with me, it's probably not typical usage for input boxes with placeholders.

@hediet
Copy link
Member Author

hediet commented Apr 26, 2024

But when there is an @ participant in the input, I still use a text decoration to show the participant description after the name.

We could support this, but I wonder how the API should look like and what benefits the placeholder feature would give over decorations.

@roblourens
Copy link
Member

It would have to be something that I add and remove, like a decoration. But it would save a few lines of code in not having to figure out the color or positioning. Low-priority, probably, I don't think anyone else would use it beyond chat right now.

@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-core Editor basic functionality feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants