-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test: let Code Actions contribute highlight range #203092
Labels
Milestone
Comments
alexr00
added a commit
to microsoft/vscode-pull-request-github
that referenced
this issue
Jan 23, 2024
This is a nice API addition. It makes it much clearer for the todo code action provider that the reason we're suggesting the action is because there's a "todo" comment. |
Agree with Alex, this way the code actions are easier to understand and the user has a way to see what has been modified. Great job 👍 |
alexr00
added a commit
to microsoft/vscode-pull-request-github
that referenced
this issue
Feb 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Refs: #199608
Complexity: 3
Create Issue
Create Issue
Overview
A proposed API that allows Code Actions to contribute a
Range
for affected lines in the editor, which will highlight those affectd lines.The following is the structure of the proposed API:
You can use this in your extension by adding this to your extension manifest (package.json):
and then run:
npx vscode-dts dev
which will fetch the proposed API and allow you to see types.To test
Some things to make sure:
Range
is implemented, the contributedRange
is 0-based, whileIRange
(which it is converted to) starts at 1.Let me know what you think overall!
Note: you must adopt this in an external extension (not a built-in to VS Code one)
Helpful links
The text was updated successfully, but these errors were encountered: