Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Json breaks for large files after roughly 50000 lines #202138

Closed
zeroflag0 opened this issue Jan 10, 2024 · 9 comments · Fixed by #202497
Closed

Json breaks for large files after roughly 50000 lines #202138

zeroflag0 opened this issue Jan 10, 2024 · 9 comments · Fixed by #202497
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority insiders-released Patch has been released in VS Code Insiders verified Verification succeeded

Comments

@zeroflag0
Copy link

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.86.0-insider (user setup)
  • OS Version: Windows_NT x64 10.0.19045
Version: 1.86.0-insider (user setup)
Commit: fb769554405bee9be16e21ceb0a496bd29126941
Date: 2024-01-09T09:57:14.563Z
Electron: 27.2.1
ElectronBuildId: 26149897
Chromium: 118.0.5993.159
Node.js: 18.17.1
V8: 11.8.172.18-electron.0
OS: Windows_NT x64 10.0.19045

Steps to Reproduce:

  1. load json (?) file with more than 52632 (for one test, the next failed at 49xxx depending on the window-size) lines
  2. scroll past line 52632 (or jump to end)

image

image

@zeroflag0 zeroflag0 changed the title Sticky Scroll breaks for large Json files after roughly 50000 lines Json breaks for large files after roughly 50000 lines Jan 10, 2024
@aeschli aeschli assigned hediet and unassigned aeschli Jan 10, 2024
@aeschli
Copy link
Contributor

aeschli commented Jan 10, 2024

I see the same. the editor no longer renders the content.

Console shows:

  ERR TextModelPart is disposed!: Error: TextModelPart is disposed!
    at l.g (vscode-file://vscode-app/usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:121:22482)
    at l.getWordAtPosition (vscode-file://vscode-app/usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:642:122472)
    at U.getWordAtPosition (vscode-file://vscode-app/usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:749:9052)
    at m.h (vscode-file://vscode-app/usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:773:73328)
    at new f (vscode-file://vscode-app/usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:773:73203)
    at new m (vscode-file://vscode-app/usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:773:73784)
    at T (vscode-file://vscode-app/usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:773:74584)
    at P.F (vscode-file://vscode-app/usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:773:79173)
    at P.E (vscode-file://vscode-app/usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:773:78908)
    at h.value (vscode-file://vscode-app/usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:773:75352)
    at d.y (vscode-file://vscode-app/usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:87:1902)
    at d.z (vscode-file://vscode-app/usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:87:1972)
    at d.fire (vscode-file://vscode-app/usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:87:2036)
    at h.value (vscode-file://vscode-app/usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:757:15263)
    at d.y (vscode-file://vscode-app/usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:87:1902)
    at d.fire (vscode-file://vscode-app/usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:87:2119)
    at E.s (vscode-file://vscode-app/usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:132:106436)
    at E.emitOutgoingEvent (vscode-file://vscode-app/usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:132:106190)
    at h.value (vscode-file://vscode-app/usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:754:22176)
    at d.y (vscode-file://vscode-app/usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:87:1902)
    at d.z (vscode-file://vscode-app/usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:87:1972)
    at d.fire (vscode-file://vscode-app/usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:87:2188)
    at I.n (vscode-file://vscode-app/usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:87:17588)
    at I.setScrollDimensions (vscode-file://vscode-app/usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:87:16330)
    at k.setScrollDimensions (vscode-file://vscode-app/usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:132:112064)
    at w.n (vscode-file://vscode-app/usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:132:114115)
    at w.onHeightMaybeChanged (vscode-file://vscode-app/usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:132:113135)
    at w.changeWhitespace (vscode-file://vscode-app/usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:132:115390)
    at $.changeWhitespace (vscode-file://vscode-app/usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:755:3855)
    at p.changeViewZones (vscode-file://vscode-app/usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:132:72557)
    at q.change (vscode-file://vscode-app/usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:736:24055)
    at x.changeViewZones (vscode-file://vscode-app/usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:757:13688)

@connor4312 connor4312 added bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority labels Jan 10, 2024
@connor4312 connor4312 assigned connor4312 and alexdima and unassigned connor4312 Jan 10, 2024
@connor4312
Copy link
Member

image

@balbertho
Copy link

It seems related to issue #202050

@connor4312
Copy link
Member

@hediet this appears to have regressed following #194712 based on a git bisect

hediet added a commit that referenced this issue Jan 15, 2024
@hediet hediet added this to the December / January 2024 milestone Jan 15, 2024
@hediet hediet closed this as completed in 8622b23 Jan 15, 2024
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jan 15, 2024
@antlaij
Copy link

antlaij commented Jan 20, 2024

I have just updated to the following version.
That fixed this large file issue
image

Thanks for the VS code team to fix this issue

@benibenj benibenj added the verified Verification succeeded label Jan 25, 2024
@aiday-mar aiday-mar added this to the December / January 2024 milestone Feb 6, 2024
@Aetherinox
Copy link

Aetherinox commented Feb 22, 2024

Came here looking for a solution, I am also having this issue, and the latest version does not correct it.

ukIArlt

To give a reference of just how much code is being cut off:

WEzLAby

Created a new profile to test this, default theme, no extensions at all.

@connor4312
Copy link
Member

connor4312 commented Feb 22, 2024

@Aetherinox based on your screenshot, you are on an old Insiders version. It's >1mo old; Insiders are published every day. Please update for the fix.

@Aetherinox
Copy link

Interesting, clicked update from within Insiders. I'll manually download again from the website and reinstall.

@Aetherinox
Copy link

Aetherinox commented Feb 22, 2024

Thanks, sorry about that. No idea why VSC didn't detect an update. Manually installing worked.
wuFpV9r

Appreciate it. Figured the commit id differences in our screenshots was because this post is a month old. Just saw the version num and other info.

@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.