Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing JS Heap Snapshots Viewer: Cursor is not a pointer when it triggers UI change #199327

Closed
aiday-mar opened this issue Nov 28, 2023 · 0 comments · Fixed by microsoft/vscode-js-profile-visualizer#161
Closed

Testing JS Heap Snapshots Viewer: Cursor is not a pointer when it triggers UI change #199327

aiday-mar opened this issue Nov 28, 2023 · 0 comments · Fixed by microsoft/vscode-js-profile-visualizer#161
Assignees
@connor4312

Comments

@aiday-mar
Copy link
Contributor

Testing #199239

This is perhaps not so important. I think that it would be nice if the cursor was in the shape of a pointer on hovering the node text, since when you click on it, it triggers a UI change.

Screen.Recording.2023-11-28.at.13.44.06.mov
connor4312 added a commit to microsoft/vscode-js-profile-visualizer that referenced this issue Nov 28, 2023
@connor4312
fix: address testing feedback
630fa39 
Fixes microsoft/vscode#199332
Fixes microsoft/vscode#199327
Fixes microsoft/vscode#199326
Fixes microsoft/vscode#199323
Fixes microsoft/vscode#199321
Fixes microsoft/vscode#199319
@connor4312 connor4312 mentioned this issue Nov 28, 2023
Merged
connor4312 added a commit to microsoft/vscode-js-profile-visualizer that referenced this issue Nov 28, 2023
@connor4312
fix: address testing feedback (#161)
90d232c 
Fixes microsoft/vscode#199332
Fixes microsoft/vscode#199327
Fixes microsoft/vscode#199326
Fixes microsoft/vscode#199323
Fixes microsoft/vscode#199321
Fixes microsoft/vscode#199319
@github-actions github-actions bot locked and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@connor4312 connor4312

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: address testing feedback microsoft/vscode-js-profile-visualizer
2 participants
@connor4312 @aiday-mar