Refactor menu's css seems missing

[fourdim]

Does this issue occur when all extensions are disabled?: Yes, but with vscode-remote enabled.

• Version: 1.85.0-insider (user setup)
• Commit: 05cd264
• Date: 2023-11-21T05:35:09.651Z
• Electron: 25.9.4
• ElectronBuildId: 25127168
• Chromium: 114.0.5735.289
• Node.js: 18.15.0
• V8: 11.4.183.29-electron.0
• OS: Windows_NT x64 10.0.19045
• Remote-SSH: v0.107.0

Steps to Reproduce:

1. Create a typescript file.
2. Select a function and click on refactor.

[gjsjohnmurray]

Do you still get this after you update to the newest Insiders?

[fourdim]

Yeah, the bug is still there.
The latest insider:

• Version: 1.85.0-insider (user setup)
• Commit: 9524207
• Date: 2023-11-22T14:33:51.941Z
• Electron: 25.9.4
• ElectronBuildId: 25127168
• Chromium: 114.0.5735.289
• Node.js: 18.15.0
• V8: 11.4.183.29-electron.0
• OS: Windows_NT x64 10.0.19045

[justschen]

I've been unable to reproduce this - do you have a reliable repro for this @fourdim ?

[fourdim]

At least it is reproducible on my side.

• Disable all the extensions.
• Create a file called a.ts
• Copy the following code to the file:

export const aa = () => {
    console.log('aa');
};

• Move the cursor to lo|g

export const aa = () => {
    console.lo|g('aa');
};

• Right click to open the menu and then click on the refactor.

[justschen]

repro:

• Linux/windows
• refactor (via menu) before hitting the lightbulb, using the quick fix menu, or using ctrl + shift + r
• Observe focused, but incorrectly rendered menu

[mirao]

The same issue is in my environment when using "Refactor" on a selected text in a TypeScript file. I'm able to reproduce it reliably.
Note it happens only if the setting window.titleBarStyle has the value custom. Value native works well.
It could be a regression in 1.85 as I didn't see the issue in 1.84.

Tested with (both environments are affected):

• Windows 11, VSCode 1.85
• Ubuntu 22.04, VSCode 1.85

[DanTup]

This is happening in stable now, the refactor menu is broken in many ways. For TypeScript it looks like this:

For Dart/Flutter, the menu just doesn't appear when you click "Refactor" in the context menu, but if you use the shortcut key it appears, and then it subsequently appears when you use the menu.

[justschen]

exploring this right now - looks like it's only happening in Windows and Linux, was unable to repro on Mac.

[justschen]

wonder if it's related to @bpasero 's change in the contextViewService af63c41

I'm seeing shadow-root where it's not supposed to be.