Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Pause' command should be hidden or disabled when not debugging #195417

Closed
gregg-miskelly opened this issue Oct 11, 2023 · 0 comments · Fixed by #200788
Closed

'Pause' command should be hidden or disabled when not debugging #195417

gregg-miskelly opened this issue Oct 11, 2023 · 0 comments · Fixed by #200788
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded

Comments

@gregg-miskelly
Copy link
Member

Type: Bug

  1. Create any launchable debug configuration, see below for a Node example
  2. Hit Ctrl-F5 to start without debugging

Expected

Since the target process is launched without debugging, the 'Pause' command should be disabled (or ideally hidden) in the debug toolbar. If disabled, hovering over it should indicate that we aren't debugging.

Actual

The command is available

Notes

I am openning this issues since I have seen several customers recently be confused because launching with and without debugging are so similar in VS Code. I believe it would help things if a few steps were taken to make these less similar

Example program (hello.js)

const readline = require('node:readline');
const { stdin: input, stdout: output } = require('node:process');

const rl = readline.createInterface({ input, output });

rl.question('Please enter some text\n', (answer) => {
  console.log(`Result: ${answer}`);
  rl.close();
});

Example launch.json

{
    "configurations": [
        {
            "name": "Launch Program",
            "program": "${workspaceFolder}/hello.js",
            "request": "launch",
            "type": "node",
            "console": "integratedTerminal"
        }
    ]
}

VS Code version: Code - Insiders 1.84.0-insider (6a7a661, 2023-10-11T05:34:23.077Z)
OS version: Windows_NT x64 10.0.22621
Modes:

System Info
Item Value
CPUs Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz (16 x 2304)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
Load (avg) undefined
Memory (System) 31.79GB (8.83GB free)
Process Argv --crash-reporter-id 8dd46428-3c33-429b-aec8-0a1119b2424f
Screen Reader no
VM 0%
@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues labels Oct 11, 2023
@connor4312 connor4312 self-assigned this Dec 13, 2023
@connor4312 connor4312 added this to the December / January 2024 milestone Dec 13, 2023
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Dec 14, 2023
@TylerLeonhardt TylerLeonhardt added the verified Verification succeeded label Jan 24, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2024
@aiday-mar aiday-mar added this to the December / January 2024 milestone Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants