Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated terminal link/file hovering doesn't include :line:column in file:// links #193629

Closed
connorskees opened this issue Sep 20, 2023 · 2 comments · Fixed by #200393
Closed
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders terminal-links verification-needed Verification of issue is requested verified Verification succeeded

Comments

@connorskees
Copy link
Contributor

When the file:// prefix is added to a file path, the line number and column number fields are not included when alt-clicking to open the file.

image

vs

image

@ssalbdivad
Copy link

This has been nagging at me forever- would love to see it fixed if it's relatively simple!

Is there any setting I can configure in the meantime to change what text is selected for these links?

Currently I'm stuck with either no position:

image

Or it highlights the whole thing, but when I click to navigate it omits file:/// and won't resolve unless I manually prepend a /:

image

@Tyriar Tyriar modified the milestones: Backlog, December / January 2024 Dec 8, 2023
@Tyriar
Copy link
Member

Tyriar commented Dec 8, 2023

file:// links don't work great today because we use the TerminalUriLinkDetector which uses monaco's link detection, this lacks a bunch of the smarts of TerminalLocalLinkDetector.

Tyriar added a commit that referenced this issue Dec 8, 2023
Tyriar added a commit that referenced this issue Dec 8, 2023
@Tyriar Tyriar added feature-request Request for new features or functionality and removed confirmation-pending labels Dec 8, 2023
Tyriar added a commit that referenced this issue Dec 8, 2023
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Dec 8, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2024
@aiday-mar aiday-mar added the verification-needed Verification of issue is requested label Jan 24, 2024
@alexr00 alexr00 added the verified Verification succeeded label Jan 24, 2024
@aiday-mar aiday-mar added this to the December / January 2024 milestone Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders terminal-links verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants