Mocha test suite factory function should not be async

[alexr00]

We discovered in #187482 (comment) that some of our suite factory methods are async and can impact other tests as a result. After discussion, we have decided that we should limit suite factory methods so they cannot be async.

The first step is to write an eslint rule to find async suite factory methods.

The second step is to fix all the places this occurs:

• src\vs\editor\contrib\find\test\browser\findController.test.ts @alexdima
• src\vs\workbench\contrib\search\test\common\extractRange.test.ts @Tyriar
• src\vs\workbench\contrib\terminal\test\common\history.test.ts @Tyriar
• src\vs\workbench\contrib\terminal\test\node\terminalProfiles.test.ts @Tyriar
• src\vs\workbench\contrib\terminal\test\browser\xterm\decorationAddon.test.ts @meganrogge
• src\vs\workbench\contrib\terminal\test\browser\xterm\shellIntegrationAddon.test.ts @Tyriar
• src\vs\workbench\contrib\terminalContrib\quickFix\test\browser\quickFixAddon.test.ts @meganrogge

[alexr00]

Once the PR for the eslint rule is in, you should just be able to see a warning by opening the file listed. To fix, make the second argument to the suite factory function sync (example: #188380).

If you need to run async code during your suite setup, consider using a suiteSetup.

[alexr00]

The PR for the lint rule causes hygiene to fail, so if you want to try the rule out to fix your change feel free to checkout #188378 and make your change on that branch.

[alexr00]

Now that debt week is beginning, please consider taking a look at the errors above so that we can merge this new eslint rule and prevent more unreliable tests to be written!

[Tyriar]

There were no awaits so I think we can just remove them all which I did in #189171, merging that will close this out.

[alexr00]

Great, thanks @Tyriar!

[Tyriar]

Oh opps, this will auto close. I see you will need to update the branch on #188378 and merge in before this is closed.