Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diff Editor: Collapse Unchanged Code - Show Context Header #185781

Closed
hediet opened this issue Jun 21, 2023 · 2 comments · Fixed by #191250
Closed

Diff Editor: Collapse Unchanged Code - Show Context Header #185781

hediet opened this issue Jun 21, 2023 · 2 comments · Fixed by #191250
Assignees
@hediet
Labels
diff-editor Diff editor issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone
August 2023

Comments

@hediet
Copy link
Member

hediet commented Jun 21, 2023 •
edited
Loading

It would be very helpful to include the current symbol name in the collapsed unmodified code indicator (see DiffEditorWidget2 and constructor):

chrome_BE4rflvO6W

Verification steps:

  • Open a diff in vscode (not monaco editor playground)
  • Enable collapsing unchanged regions (map icon in editor titlebar)
  • Observe that the collapsed code shows a header indicating which symbol started inside of the unchanged code but ended outside of it.
  • Verify that clicking on it reveals the symbol
@hediet hediet added feature-request Request for new features or functionality diff-editor Diff editor issues labels Jun 21, 2023
@hediet hediet added this to the June 2023 milestone Jun 21, 2023
@hediet hediet self-assigned this Jun 21, 2023
@hediet hediet modified the milestones: June 2023, July 2023 Jun 27, 2023
@hediet hediet modified the milestones: July 2023, August 2023 Jul 18, 2023
@hediet hediet mentioned this issue Aug 24, 2023
Merged
hediet added a commit that referenced this issue Aug 24, 2023
@hediet
Fixes #185781
2e69070
hediet added a commit that referenced this issue Aug 24, 2023
@hediet
Fixes #185781
885ebcd
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 24, 2023
@hediet hediet added the verification-needed Verification of issue is requested label Aug 29, 2023
@bpasero
Copy link
Member

bpasero commented Aug 29, 2023

I cannot click on the left hand side to expand:

image

Also, is the hover color themable?

@bpasero bpasero reopened this Aug 29, 2023
@bpasero bpasero added the verification-found Issue verification failed label Aug 29, 2023
@vscodenpa vscodenpa removed the insiders-released Patch has been released in VS Code Insiders label Aug 29, 2023
@hediet
Copy link
Member Author

hediet commented Aug 29, 2023 •
edited
Loading

Also, is the hover color themable?

Yes.

I cannot click on the left hand side to expand:

This is a bug, thanks for discovering! I think creating a bug would be better though than reopening the feature request.

@bpasero bpasero closed this as completed Aug 29, 2023
@bpasero bpasero added verified Verification succeeded and removed verification-found Issue verification failed labels Aug 29, 2023
@bpasero bpasero mentioned this issue Aug 29, 2023
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hediet hediet

Labels
diff-editor Diff editor issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
August 2023
Development

Successfully merging a pull request may close this issue.

Collapse Unchanged Cote Context Headers, fixes #185781 microsoft/vscode
3 participants
@bpasero @hediet @vscodenpa