Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VSCODE_ENV_* variables to adjust environment in shell integration script do not work #181934

Closed
karrtikr opened this issue May 9, 2023 · 2 comments · Fixed by #182781
Closed

VSCODE_ENV_* variables to adjust environment in shell integration script do not work #181934

karrtikr opened this issue May 9, 2023 · 2 comments · Fixed by #182781
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal General terminal issues that don't fall under another label terminal-shell-integration Shell integration infrastructure, command decorations, etc. verified Verification succeeded
Milestone
May 2023

Comments

@karrtikr
Copy link
Contributor

karrtikr commented May 9, 2023

For #179476 (comment)

image
image
image
image
@karrtikr karrtikr added the terminal General terminal issues that don't fall under another label label May 9, 2023
@karrtikr karrtikr added this to the May 2023 milestone May 9, 2023
@Tyriar Tyriar added the bug Issue identified by VS Code Team member as probable bug label May 9, 2023
@Tyriar
Copy link
Member

Tyriar commented May 15, 2023

The main issue here is in practice the separators : are used in the values as well, this just wasn't covered properly initially

Tyriar added a commit that referenced this issue May 17, 2023
@Tyriar
Use encoded x3a to represent colon in bash
1d634d9 
Part of #181934
@Tyriar Tyriar mentioned this issue May 17, 2023
Merged
@Tyriar Tyriar added the terminal-shell-integration Shell integration infrastructure, command decorations, etc. label May 17, 2023
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 17, 2023
@Tyriar
Copy link
Member

Tyriar commented Jun 1, 2023

This has been verified by @karrtikr already, there is an issue with fish still that we're tracking elsewhere

@Tyriar Tyriar added the verified Verification succeeded label Jun 1, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal General terminal issues that don't fall under another label terminal-shell-integration Shell integration infrastructure, command decorations, etc. verified Verification succeeded
Projects
None yet
Milestone
May 2023
Development

Successfully merging a pull request may close this issue.

Support : in values for VSCODE_ENV_* variables microsoft/vscode
3 participants
@Tyriar @karrtikr @vscodenpa