Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colour picker's sticky hover doesn't work when hover is disabled #179575

Closed
starball5 opened this issue Apr 9, 2023 · 3 comments · Fixed by #184079
Closed

Colour picker's sticky hover doesn't work when hover is disabled #179575

starball5 opened this issue Apr 9, 2023 · 3 comments · Fixed by #184079
Assignees
Labels
editor-hover Editor mouse hover insiders-released Patch has been released in VS Code Insiders

Comments

@starball5
Copy link

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.77.2
  • OS Version: Ubuntu 22.04.1

Steps to Reproduce:

  1. Put "editor.hover.enabled": false in settings.json, and ensure "editor.hover.sticky" is either not set (default is true), or is set explicitly to true.
  2. Write anything that creates a colour decoration, such as a color property in a CSS style rule.
  3. Click the colour decoration to cause the colour picker hover to open.
  4. Move the mouse off of the decoration an onto the opened hover.
  5. Observe that the open hover closes once the mouse touches it.

I also observe that if one uses the Show or Focus Hover command instead with these settings, the mouse can enter the opened hover area just fine without it auto-closing.

Possibly related issue tickets: #40634, #139746, #69066

@vscodenpa
Copy link

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.77.1. Please try upgrading to the latest version and checking whether this issue remains.

Happy Coding!

@Chaos-070799
Copy link

Chaos-070799 commented Apr 9, 2023 via email

@rebornix rebornix assigned aiday-mar and unassigned rebornix Apr 10, 2023
@aiday-mar aiday-mar added the editor-hover Editor mouse hover label Apr 11, 2023
@haykam821
Copy link
Contributor

I think that the color picker should be activated by clicking the color decorator and closed manually rather than when the mouse leaves the color picker. The current behavior is unintuitive to me, and this issue (along with a general lack of configurability in this area as noted by other issues) prevents me from implementing my preference of behavior.

The color picker shouldn't close automatically if the user has interacted with it at all, whether that's through clicking the color decorator or by changing the color. The latter issue is covered by #33568.

@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 2, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-hover Editor mouse hover insiders-released Patch has been released in VS Code Insiders
Projects
None yet
6 participants