Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

acceptNextWord should treat consecutive whitespaces as one part #174329

Closed
bmuskalla opened this issue Feb 14, 2023 · 6 comments · Fixed by #179988
Closed

acceptNextWord should treat consecutive whitespaces as one part #174329

bmuskalla opened this issue Feb 14, 2023 · 6 comments · Fixed by #179988
Assignees
@hediet
Labels
feature-request Request for new features or functionality inline-completions insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
April 2023

Comments

@bmuskalla
Copy link

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version: Version: 1.76.0-insider (Universal)
    Commit: 853b32b

Steps to Reproduce:

  1. Inline suggestion with multiple whitespaces (leading or in between)
  2. Partially accept the whitespaces

Expected:
Suggestion is accepted up to the next non-whitespace character.

Actual:
Each whitespace will be accepted individually.

Recording 2023-02-14 at 11 39 42

cc @hediet
@bmuskalla bmuskalla changed the title acceptNextWord should treat conseqsive whitespaces as one part acceptNextWord should treat consecutive whitespaces as one part Feb 14, 2023
@hediet hediet assigned hediet and unassigned jrieken Feb 17, 2023
@hediet hediet added help wanted Issues identified as good community contribution opportunities feature-request Request for new features or functionality inline-completions good first issue Issues identified as good for first-time contributors labels Feb 17, 2023
@hediet hediet added this to the February 2023 milestone Feb 17, 2023
@piyush09-05
Copy link

I would like to work on. Can you please assign this issue to me?

@hediet hediet modified the milestones: February 2023, On Deck Feb 20, 2023
@MatteoPossamai
Copy link

I would like to work on this issue if I can. Can you please describe better the issue because I did not understand what I should do

@Gardezi1
Copy link

@hediet can you share the link to the v1.76.0-insider release version? I think it's specific to that version but I'm unable to find that release version

@monish-byte
Copy link

hey @hediet I'm a beginner in open source, I want to work on this issue can you please guide me on how I can get started?

@Brandodan5621
Copy link

Brandodan5621 commented Apr 3, 2023 •
edited
Loading

@hediet Can I work on this issue too?

@balaji-sivasakthi
Copy link
Contributor

balaji-sivasakthi commented Apr 4, 2023 •
edited
Loading

Hey @bmuskalla, I've recently checked your issue and that's working fine. I think out that your issue caused by Github Copilot. Please make sure it.

Screenshot (64)

hediet added a commit that referenced this issue Apr 14, 2023
@hediet
Rewrites the inline completion feature.
e619464 
Fixes #172162
Fixes #174329
Fixes #172153
Fixes #164716
@hediet hediet mentioned this issue Apr 14, 2023
Merged
hediet added a commit that referenced this issue Apr 17, 2023
@hediet
Rewrites the inline completion feature.
5170534 
Fixes #172162
Fixes #174329
Fixes #172153
Fixes #164716
Fixes #170527
hediet added a commit that referenced this issue Apr 17, 2023
@hediet
Rewrites the inline completion feature.
fb1af29 
Fixes #172162
Fixes #174329
Fixes #172153
Fixes #164716
Fixes #170527
hediet added a commit that referenced this issue Apr 17, 2023
@hediet
Rewrites the inline completion feature.
cb0e59c 
Fixes #172162
Fixes #174329
Fixes #172153
Fixes #164716
Fixes #170527
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Apr 17, 2023
@hediet hediet modified the milestones: On Deck, April 2023 Apr 21, 2023
@hediet hediet removed help wanted Issues identified as good community contribution opportunities good first issue Issues identified as good for first-time contributors labels Apr 24, 2023
@hediet hediet added the verification-needed Verification of issue is requested label Apr 24, 2023
@ulugbekna ulugbekna added verified Verification succeeded and removed verification-needed Verification of issue is requested labels Apr 25, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hediet hediet

Labels
feature-request Request for new features or functionality inline-completions insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
April 2023
Development

Successfully merging a pull request may close this issue.

Rewrites the inline completion feature. microsoft/vscode