$TM_SELECTED_TEXT overtyping not functioning as expected in snippets for latex files

[Walker-Xin]

Does this issue occur when all extensions are disabled?: Yes

• Version: 1.74.2 (user setup)
• Commit: e8a3071
• Date: 2022-12-20T10:29:14.590Z
• Electron: 19.1.8
• Chromium: 102.0.5005.167
• Node.js: 16.14.2
• V8: 10.2.154.15-electron.0
• OS: Windows_NT x64 10.0.22621
• Sandboxed: No

Steps to Reproduce:

1. Create a snippet for latex that uses $TM_SELECTED_TEXT. The following is an example that wraps selected text in auto-sized brackets:

"big ()": {
   	"prefix": ["lr"],
   	"body": [
   		"\\left( $TM_SELECTED_TEXT \\right)",
   	],
   	"description": "Begin auto-sized braket"
 },

2. Type 'lr' over a selected text and hit TAB. The selected text is not included in the output.

3. Using F1 + Insert Snippet, however, produces the desired output.

I have only encountered the problem in latex environment, including inline math in markdown files.

The issue was raised in #167364 and was fixed in 1.73 update via #165871 (I think). But came back in 1.74.

[jrieken]

The problem is the latex word definition which requires two characters to be typed... This is what happens

• overtyping happens, we capture the overtyped text, and "await" the next suggest session to start
• this doesn't happen because suggest only auto starts at word ends and a single character is no word
• the next character is typed, erasing the overtyped, captured value
• suggest starts because the 2nd character makes this a word

@alexr00 looping you in here and wonder if you know why such a word definition was chosen and if it can be changed

[alexr00]

I don't know why the definition specifies 2 characters. I'm not familiar enough with latex to know if there's a reason for it. Given that no other language does this I would be fine to remove it.

[jrieken]

+1 for changing the word definition. FYO @jlelong who originally added this via 0e52a75

[jlelong]

I confirm that changing the word definition to 1 character is fine.

[vscodenpa]

This bug has been fixed in the latest release of VS Code Insiders!

@Walker-Xin, you can help us out by commenting /verified if things are now working as expected.

If things still don't seem right, please ensure you're on version 0a6c277 of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!

[Walker-Xin]

/verified