Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing placeholder text #167767

Closed
jrieken opened this issue Nov 30, 2022 · 2 comments
Closed

Missing placeholder text #167767

jrieken opened this issue Nov 30, 2022 · 2 comments
Assignees
@rebornix
Labels
insiders-released Patch has been released in VS Code Insiders notebook-kernel-picker polish Cleanup and polish issue ux User experience issues
Milestone
January 2023

Comments

@jrieken
Copy link
Member

jrieken commented Nov 30, 2022

Testing microsoft/vscode-jupyter#11963

  • select "Select Another Kernel"
  • the next page has no placeholder text

Screenshot 2022-11-30 at 11 32 36
@jrieken
Copy link
Member Author

jrieken commented Nov 30, 2022

Placeholder text seems to be missing in all the pages of this flow... please consult the new QP guidelines

cc @daviddossett

@daviddossett
Copy link
Contributor

For reference since it hasn't landed on the docs site yet: #158895 (comment)

@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-jupyter Nov 30, 2022
@DonJayamanne DonJayamanne removed their assignment Nov 30, 2022
@rebornix rebornix added polish Cleanup and polish issue notebook-kernel-picker labels Dec 1, 2022
@rebornix rebornix added this to the December 2022 milestone Dec 1, 2022
@rebornix rebornix added the ux User experience issues label Dec 1, 2022
rebornix added a commit that referenced this issue Dec 20, 2022
@rebornix
Fix #167767. Add kernel picker placeholder
bef05f0
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Dec 20, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

Labels
insiders-released Patch has been released in VS Code Insiders notebook-kernel-picker polish Cleanup and polish issue ux User experience issues
Projects
None yet
Milestone
January 2023
Development

No branches or pull requests
5 participants
@rebornix @jrieken @DonJayamanne @daviddossett @vscodenpa