Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Odd extra tabstop on setting #167629

Closed
mjbvz opened this issue Nov 29, 2022 · 2 comments · Fixed by #167753
Closed

Odd extra tabstop on setting #167629

mjbvz opened this issue Nov 29, 2022 · 2 comments · Fixed by #167753
Assignees
@rzhao271
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues
Milestone
January 2025

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Nov 29, 2022

Testing #167084

  1. Follow the steps from Test: Simple settings indicators accessibility #167084
  2. In emmet.extensionsPath, keep tabbing a few more times

Bug
One of the tab stops selects this horizontal line element:

Screenshot 2022-11-29 at 12 53 27 PM

I think this is an empty list but it is odd that it gets selected here
@rzhao271 rzhao271 added bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues labels Nov 29, 2022
@rzhao271 rzhao271 modified the milestones: Backlog, November 2022 Nov 29, 2022
@rzhao271 rzhao271 added the accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues label Nov 30, 2022
@rzhao271 rzhao271 mentioned this issue Nov 30, 2022
Merged
rzhao271 added a commit that referenced this issue Nov 30, 2022
@rzhao271
Add tabIndex only when there's data
8faffa2 
Fixes #167629
rzhao271 added a commit that referenced this issue Nov 30, 2022
@rzhao271
Add tabIndex only when there's data (#167753)
dfca1c7 
Fixes #167629
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 30, 2022
@eleanorjboyd eleanorjboyd added the verified Verification succeeded label Dec 1, 2022
@eleanorjboyd
Copy link
Member

I am still seeing this issue occurring in the most recent version of insiders

Screenshot 2022-12-01 at 2 06 42 PM

@eleanorjboyd eleanorjboyd added verification-found Issue verification failed and removed verified Verification succeeded labels Dec 1, 2022
@rzhao271 rzhao271 reopened this Dec 2, 2022
@rzhao271 rzhao271 modified the milestones: November 2022, December 2022 Dec 2, 2022
@vscodenpa vscodenpa removed the insiders-released Patch has been released in VS Code Insiders label Dec 2, 2022
@rzhao271 rzhao271 modified the milestones: December 2022, Backlog Dec 6, 2022
@rzhao271
Copy link
Contributor

Unable to repro. Moving to January for verification.

@rzhao271 rzhao271 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 10, 2024
@rzhao271 rzhao271 removed the verification-found Issue verification failed label Dec 10, 2024
@rzhao271 rzhao271 modified the milestones: Backlog, January 2025 Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rzhao271 rzhao271

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues
Projects
None yet
Milestone
January 2025
Development

Successfully merging a pull request may close this issue.

Add tabIndex only when there's data microsoft/vscode
4 participants
@rzhao271 @mjbvz @eleanorjboyd @vscodenpa