Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit session identity providers should tolerate minor differences in identity #162120

Closed
Tracked by #163077
bpasero opened this issue Sep 28, 2022 · 6 comments
Closed
Tracked by #163077
Assignees
Labels
feature-request Request for new features or functionality polish Cleanup and polish issue verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Sep 28, 2022

Testing #161875

I tried to continue from desktop and was greeted with this:

image

Logs:

Access to XMLHttpRequest at 'https://vscode-sync.trafficmanager.net/v1/resource/editSessions' from origin 'vscode-file://vscode-app' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.

Looks like CORS is not enabled for vscode-file://vscode-app origin.

@bpasero bpasero added the important Issue identified as high-priority label Sep 28, 2022
@joyceerhl
Copy link
Collaborator

Is this a local folder that you have open in vscode.dev, or a local folder that you have open in the desktop app?

FWIW I believe there were some access control issues with the service which @lszomoru has now resolved.

@joyceerhl joyceerhl added the info-needed Issue requires more information from poster label Sep 28, 2022
@bpasero
Copy link
Member Author

bpasero commented Sep 29, 2022

Now the browser opened but the 2 files not restored. This is a local folder where I want to continue on vscode.dev.

Logs:

[2022-09-29 08:43:49.152] [editsessions] [info] Resuming edit session, reason: found editSessionId 181725b5-f67f-4790-bb60-8f7c3a18c711 in environment service...
[2022-09-29 08:43:49.249] [editsessions] [info] Resuming edit session with ref 181725b5-f67f-4790-bb60-8f7c3a18c711...
[2022-09-29 08:43:49.367] [editsessions] [info] Searching for existing authentication session with ID 525f4f5a-dd19-4054-a34a-d2c52cc53740
[2022-09-29 08:43:49.483] [editsessions] [info] Found existing authentication session with ID 525f4f5a-dd19-4054-a34a-d2c52cc53740
[2022-09-29 08:43:49.574] [editsessions] [info] Matching identity {"remote":"https://github.com/microsoft/vscode-extension-samples","ref":"main","sha":"fdd3bb95ce8e38ffe58fc9158797239fdf5017f1"} against edit session folder identity {"remote":"https://github.com/microsoft/vscode-extension-samples.git","ref":"main","sha":"fdd3bb95ce8e38ffe58fc9158797239fdf5017f1"}...
[2022-09-29 08:43:49.640] [editsessions] [info] Skipping applying 2 changes from edit session with ref 181725b5-f67f-4790-bb60-8f7c3a18c711 as no matching workspace folder was found.

@joyceerhl joyceerhl changed the title Cannot continue on vscode.dev from desktop Edit session identity providers should tolerate minor differences in identity Sep 29, 2022
@joyceerhl joyceerhl added feature-request Request for new features or functionality polish Cleanup and polish issue and removed info-needed Issue requires more information from poster important Issue identified as high-priority labels Sep 29, 2022
@joyceerhl joyceerhl added this to the October 2022 milestone Sep 29, 2022
@joyceerhl
Copy link
Collaborator

Temporary workaround: git remote set-url https://github.com/microsoft/vscode-extension-samples. The real fix is to allow edit session identity providers to tolerate minor differences in the identity, I rename this issue to reflect that.

@bpasero
Copy link
Member Author

bpasero commented Sep 30, 2022

To clarify, what is the minor difference here that resulted in the issue?

@joyceerhl
Copy link
Collaborator

The remote ends in .git in one window but not the other.

@joyceerhl
Copy link
Collaborator

Verification:

  1. In desktop VS Code on main branch, git remote set-url origin https://github.com/microsoft/vscode.git
  2. In https://vscode.dev/github/microsoft/vscode on main branch, create uncommitted changes and then Store Current Edit Session
  3. In desktop VS Code, Resume Latest Edit Session
  4. Edits from vscode.dev should be applied in desktop -- previously they would have been skipped

@joyceerhl joyceerhl added the verification-needed Verification of issue is requested label Oct 24, 2022
@rzhao271 rzhao271 added the verified Verification succeeded label Oct 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality polish Cleanup and polish issue verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants