Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test updating markdown paths on file move/rename #158416

Closed
3 tasks done
mjbvz opened this issue Aug 17, 2022 · 4 comments
Closed
3 tasks done

Test updating markdown paths on file move/rename #158416

mjbvz opened this issue Aug 17, 2022 · 4 comments

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Aug 17, 2022

Test for #148146

Complexity: 4

Create Issue


Overview

This new feature allows markdown to automatically update all markdown links when a file is renamed/moved in the workspace. This is only supported for file moves/renames that happen within VS Code's explorer. It is also only supported for markdown style links (not html <a> links inside markdown)

Testing

  • Enable this new behavior using "markdown.experimental.updateLinksOnFileMove.enabled": "prompt"

  • Create some markdown links to local files:

    For this, try out some of these variants:

    • [text](/workspace/root/path/to/file.md)
    • [text](relative/path/to/file.md)
    • [text](path/fileNoExt) (should reference path/fileNoExt.md)
    • [text](path/file.md#some-header)
    • ![alt](path/img.png)
    • [definition]: /path/to/file.md
  • Ensure that with prompt, renaming or moving any md or image file triggers a dialog that lets you update all markdown links

  • Now try renaming some directories that contain the referenced files. Ensure this also triggers a update

  • Finally try changing markdown.experimental.updateLinksOnFileMove.externalFileGlobs. This setting controls the types of files we try updating paths for (we always enable it for markdown files).

    The default value enables it for common image file names. Try enabling it for .js files or some other format too

@mjbvz mjbvz added this to the August 2022 milestone Aug 17, 2022
@connor4312
Copy link
Member

This doesn't work for me at all on Linux. Are there missing steps?

22-08-b08e21f5-8a38-4972-bab4-1699c6e8f942.mp4

@mjbvz
Copy link
Collaborator Author

mjbvz commented Aug 23, 2022

Yes something is broken so please hold off on testing this

@mjbvz
Copy link
Collaborator Author

mjbvz commented Aug 23, 2022

Should by fixed by #158965 but you'll need to be on tomorrow's insiders build to test

@Yoyokrazy
Copy link
Contributor

Same user vs workspace setting issue as connor in #159084

Otherwise working as intended

@rzhao271 rzhao271 assigned rzhao271 and unassigned rebornix and rzhao271 Aug 24, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants