Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error telemetry: always start to deminify stacks #15752

Closed
bpasero opened this issue Nov 19, 2016 · 2 comments
Closed

Error telemetry: always start to deminify stacks #15752

bpasero opened this issue Nov 19, 2016 · 2 comments
Assignees
@ramya-rao-a
Labels
error-telemetry VS Code - Issues generated by telemetry feature-request Request for new features or functionality

Comments

@bpasero
Copy link
Member

bpasero commented Nov 19, 2016

I think there is no reason to click on an error in telemetry and not run the deminification, so why not just start it right when clicking on an error?
@ramya-rao-a ramya-rao-a added the error-telemetry VS Code - Issues generated by telemetry label Nov 19, 2016
@ramya-rao-a
Copy link
Contributor

True, for a given vscode version, there is only 1 call to make to get the source maps which we can do upfront.

@ramya-rao-a ramya-rao-a added the feature-request Request for new features or functionality label Nov 19, 2016
@kieferrm kieferrm mentioned this issue Nov 21, 2016
Closed
@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Dec 2, 2016 •
edited
Loading

Fixed with https://monacotools.visualstudio.com/Monaco/_git/VSCodeInternal/commit/6a7215d271a6256ccb8d59a378e5fc03504967ef

Hard refresh to get rid of cache to see the changes

Correction on #15752 (comment) :
Call to get sourcemaps is made once for each file in the callstack not once for each vscode version.
If the same file occurs in multiple error call stacks, then the call is not made again as long as you are in the same session

@egamma egamma mentioned this issue Dec 20, 2016
Closed
56 tasks
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ramya-rao-a ramya-rao-a

Labels
error-telemetry VS Code - Issues generated by telemetry feature-request Request for new features or functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bpasero @ramya-rao-a