-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Anchor hrefs in jupyter output are not working #153032
Comments
Thanks for the issue. I believe QuantStack would likely have to fix this. I think they're opening a URL that doesn't exist. |
It feels a bit odd for this to be on the QuantStack side... it seems like the Jupyter render is seeing a button click on a node as needing to open a URL, when in native Jupyter Lab it instead fires a javascript call. |
@rchiodo I think this is a problem with the handling of anchor tags Repro steps: Run a cell with the following code in Jupyter (or generate an output that contains the same output)
@mjbvz might have some idea what needs to be done here. |
This can repro without using ipytree. Just use the example that Don provided. |
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.68.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding! |
Fixes #153032 This fixes our handling of `href="#"` on links in notebooks
Fixes #153032 This fixes our handling of `href="#"` on links in notebooks
The very useful ipytree Jupyter Widget does not function inside the vscode notebook editor.
When clicking on a node in the tree, a model dialog is popped up, which looks like is responding to an attempt to open a editor window that is associated with the node content or some part of the underlying HTML attached to the node.
The same code in a Jupyter Lab web instance functions as expected.
This issue is mentioned in the ipytree Github here
Environment data
Expected behaviour
Click on ipytree node and UI updates with any attach callback firing
Actual behaviour
Model popup error
Steps to reproduce:
Following instructions on https://github.com/QuantStack/ipytree
run example code eg:
And then click on the node
The text was updated successfully, but these errors were encountered: