Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smoketest: VSCode Smoke Tests (Electron) Terminal Terminal splitCwd #152451

Closed
jrieken opened this issue Jun 17, 2022 · 2 comments · Fixed by #152484
Closed

smoketest: VSCode Smoke Tests (Electron) Terminal Terminal splitCwd #152451

jrieken opened this issue Jun 17, 2022 · 2 comments · Fixed by #152484
Assignees
@Tyriar
Labels
insiders-released Patch has been released in VS Code Insiders smoke-test-failure
Milestone
June 2022

Comments

@jrieken
Copy link
Member

jrieken commented Jun 17, 2022

https://dev.azure.com/monacotools/Monaco/_build/results?buildId=174719&view=logs&j=e5bbec05-0f06-558d-ebe9-5973d52063d2&t=a671546b-2469-5fb1-b2c9-08e628dcad6d
@supremeQueen21
Copy link

Hi sorry to hear that you smoke test failed call your council for smoke alarms checks

@Tyriar Tyriar added this to the June 2022 milestone Jun 17, 2022
@Tyriar
Copy link
Member

Tyriar commented Jun 17, 2022

I guess it's not time to enable them for desktop/remote yet.

@supremeQueen21 thanks for the advice 👌

@Tyriar Tyriar mentioned this issue Jun 17, 2022
Closed
Tyriar added a commit that referenced this issue Jun 17, 2022
@Tyriar
Disable terminal smoke tests on desktop/remote
1ca9725 
Fixes #152451
@Tyriar Tyriar mentioned this issue Jun 17, 2022
Merged
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Jun 17, 2022
@Tyriar Tyriar mentioned this issue Jun 17, 2022
Closed
Tyriar added a commit that referenced this issue Jun 17, 2022
@Tyriar
Use new method for settings in terminal split cwd smoke test
52bca5d 
I doubt this will fix the flake, but it's the right way to do things now.

Part of #152451
Tyriar added a commit that referenced this issue Jun 17, 2022
@Tyriar
Use new method for settings in terminal split cwd smoke test
8e29aa4 
I doubt this will fix the flake, but it's the right way to do things now.

Part of #152451
@Tyriar Tyriar mentioned this issue Jun 17, 2022
Merged
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 20, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2022
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
@Tyriar
Disable terminal smoke tests on desktop/remote
46528ea 
Fixes microsoft#152451
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
insiders-released Patch has been released in VS Code Insiders smoke-test-failure
Projects
None yet
Milestone
June 2022
Development

Successfully merging a pull request may close this issue.

Disable terminal smoke tests on desktop/remote microsoft/vscode
4 participants
@jrieken @Tyriar @vscodenpa @supremeQueen21