-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retain selected kernel in untitled notebook when saving notebook #151158
Comments
I think this is because technically the cells were run in the context of the previous notebook, so I now need to run them again after saving the notebook, which is a rather nasty limitation... |
I think this is because after saving we don't have a kernel connected to the newly saved notebook. There is no kernel session transfer (from untitled to saved notebook) currently. |
Save As is handled by core. Need to transfer current controller to new ipynb. |
Seems related to #150890? |
Not sure @Tyriar - we are handling this the same way we persist selection and other view state. But the editor still gets reopened with a new model. Dunno how this concept works in custom editors. |
Custom editors have one the untitled editor closed and a new one with another URI open, I want a signal that a custom editor can handle to upgrade it so no close/open needs to happen |
Fixes #151158 Also fix cachine the previously selected kernel for Untitled-1 after saving it
Fixes #151158 Also fix cachine the previously selected kernel for Untitled-1 after saving it
Steps:
The "Set kernel as default" gear icon in the kernel picker was also removed. |
Verified with this "kernel"
|
Testing microsoft/vscode-jupyter#10183
The text was updated successfully, but these errors were encountered: