Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown: rename failed to apply edits when invalid link to file #148147

Closed
isidorn opened this issue Apr 26, 2022 · 2 comments
Closed

Markdown: rename failed to apply edits when invalid link to file #148147

isidorn opened this issue Apr 26, 2022 · 2 comments
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders markdown Markdown support issues verified Verification succeeded
Milestone
May 2022

Comments

@isidorn
Copy link
Contributor

isidorn commented Apr 26, 2022

Testing #147738

  1. Open https://github.com/microsoft/vscode-docs/blob/vnext/release-notes/June_2016.md#L15
  2. Have the following content
[link](./July_222016.md)
  1. Try to rename the file. It fails with an error: "failed to apply edits" 🐛

I would expect that at least the rename of my selected symbol would work (even though it does not point to anything).

Screenshot 2022-04-26 at 14 55 28
@isidorn
Copy link
Contributor Author

isidorn commented Apr 26, 2022

Also happens when I do not use the .md extension in the link

@mjbvz mjbvz mentioned this issue Apr 30, 2022
Closed
@mjbvz mjbvz added this to the May 2022 milestone Apr 30, 2022
@mjbvz mjbvz added markdown Markdown support issues feature-request Request for new features or functionality labels Apr 30, 2022
@mjbvz mjbvz closed this as completed in 8449a9f Apr 30, 2022
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug and removed feature-request Request for new features or functionality labels Apr 30, 2022
@mjbvz
Copy link
Collaborator

mjbvz commented Apr 30, 2022

This should now work. Let me know if you notice any issues

(I also opened a separate issue to investigate rename without the .md: #148490)

@isidorn isidorn added verified Verification succeeded and removed verified Verification succeeded labels May 2, 2022
aeschli pushed a commit that referenced this issue May 2, 2022
@mjbvz @aeschli
Fix md rename when file does not exist
80c552a 
Fixes #148147

- Don't try renaming non-existent files
- Also fixes a bug where renaming in untitled files would insert `untitled:`
@isidorn isidorn added the verified Verification succeeded label Jun 1, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders markdown Markdown support issues verified Verification succeeded
Projects
None yet
Milestone
May 2022
Development

No branches or pull requests
3 participants
@isidorn @mjbvz and others