Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can Emmet expand and wrap abbreviation commands use ghost text? #139247

Closed
rzhao271 opened this issue Dec 16, 2021 · 2 comments · Fixed by #147387
Closed

Can Emmet expand and wrap abbreviation commands use ghost text? #139247

rzhao271 opened this issue Dec 16, 2021 · 2 comments · Fixed by #147387
Assignees
@rzhao271
Labels
emmet Emmet related issues feature-request Request for new features or functionality ghost-text Issues related to ghost text (used for inline-completions and suggestion preview) on-testplan wont-fix

Comments

@rzhao271
Copy link
Contributor

rzhao271 commented Dec 16, 2021 •
edited
Loading

Currently, the wrap with abbreviation command uses a custom implementation that interferes with the undo/redo state during the preview, and the expand abbreviation command uses non-inline suggestions.
This feature request is to track those Emmet commands making use of ghost text.
@rzhao271 rzhao271 added feature-request Request for new features or functionality emmet Emmet related issues ghost-text Issues related to ghost text (used for inline-completions and suggestion preview) labels Dec 16, 2021
@rzhao271 rzhao271 added this to the January 2022 milestone Dec 16, 2021
@rzhao271 rzhao271 self-assigned this Dec 16, 2021
@kieferrm kieferrm mentioned this issue Dec 21, 2021
Closed
91 tasks
@rzhao271 rzhao271 modified the milestones: January 2022, March 2022 Jan 24, 2022
@kieferrm kieferrm mentioned this issue Feb 7, 2022
Closed
81 tasks
@kieferrm kieferrm mentioned this issue Mar 6, 2022
Closed
87 tasks
@rzhao271 rzhao271 modified the milestones: March 2022, April 2022 Mar 21, 2022
@kieferrm kieferrm mentioned this issue Apr 3, 2022
Closed
@hediet hediet mentioned this issue Apr 13, 2022
Merged
@rzhao271
Copy link
Contributor Author

Reopening due to some small bugs I found.

@rzhao271 rzhao271 reopened this Apr 21, 2022
@rzhao271 rzhao271 removed the insiders-released Patch has been released in VS Code Insiders label Apr 21, 2022
@rzhao271 rzhao271 modified the milestones: April 2022, May 2022 Apr 21, 2022
@kieferrm kieferrm mentioned this issue Apr 26, 2022
Closed
15 tasks
@kieferrm kieferrm mentioned this issue May 7, 2022
Closed
99 tasks
@rzhao271 rzhao271 modified the milestones: May 2022, June 2022 May 25, 2022
@rzhao271 rzhao271 mentioned this issue Jun 8, 2022
Merged
2 tasks
@kieferrm kieferrm mentioned this issue Jun 11, 2022
Closed
99 tasks
rzhao271 added a commit that referenced this issue Jun 14, 2022
@rzhao271 @hediet
Emmet inline completions (#151559)
76f65c4 
Affects #139247

This PR changes Emmet to use inline completions when suggesting completions.
It also provides a boolean setting so that users can opt out.
This PR does not change the "Wrap with Abbreviation" behaviour in Emmet.

Co-authored-by: Henning Dieterichs <[email protected]>
@rzhao271 rzhao271 mentioned this issue Jun 15, 2022
Closed
2 tasks
@rzhao271 rzhao271 mentioned this issue Jun 21, 2022
Merged
@rzhao271 rzhao271 modified the milestones: June 2022, July 2022 Jun 27, 2022
@rzhao271 rzhao271 mentioned this issue Jul 1, 2022
Merged
rzhao271 added a commit that referenced this issue Jul 1, 2022
@rzhao271
Disable inline completions by default for Emmet (#153926)
623cde6 
Ref #139247
@rzhao271 rzhao271 modified the milestones: July 2022, August 2022 Jul 21, 2022
@rzhao271 rzhao271 modified the milestones: August 2022, On Deck Aug 23, 2022
@rzhao271
Copy link
Contributor Author

rzhao271 commented Dec 6, 2022

Marking as wontfix for now. I don't think it's worth switching over the entire Wrap with Abbreviation command implementation.

@rzhao271 rzhao271 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 6, 2022
@rzhao271 rzhao271 removed this from the On Deck milestone Dec 6, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rzhao271 rzhao271

Labels
emmet Emmet related issues feature-request Request for new features or functionality ghost-text Issues related to ghost text (used for inline-completions and suggestion preview) on-testplan wont-fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Provide emmet abbreviations via inline completions microsoft/vscode
2 participants
@rzhao271 and others