Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not continuously prompt User to download Java Extension from Microsoft #136301

Closed
alokkumarsinha opened this issue Nov 2, 2021 · 21 comments
Closed

Do not continuously prompt User to download Java Extension from Microsoft #136301

alokkumarsinha opened this issue Nov 2, 2021 · 21 comments
Assignees
@isidorn @sandy081
Labels
extension-recommendations Extension recommendations issues extensions Issues concerning extensions feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone
February 2022

Comments

@alokkumarsinha
Copy link

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version:
  • OS Version:

Steps to Reproduce:

  1. Install Graal Tools for Java Extension Pack
  2. Create a project (or create a Java class)
  3. On every create, Microsoft keeps giving a recommendation to install MS Java Extension (and other components like Language Server). The user already has all of these installed when they have installed Graal Tool for Java from Oracle.

Java Exten Recommendation
@gjsjohnmurray
Copy link
Contributor

Does the gear wheel button offer you any further options?

@alokkumarsinha
Copy link
Author

alokkumarsinha commented Nov 2, 2021 •
edited
Loading

Ah, we have always 'deleted' the button using 'x'. Tried the Gear and picked don't recommend again and it seems to have stopped. I will ask some others to try it.

Related question: is there an API Graal Team can call to disable this prompt altogether when we install Graal Tool for Java VS Code Extension. Very confusing for the developer

@sandy081
Copy link
Member

sandy081 commented Nov 3, 2021

Can you please check what extensions this is recommending? And do you have those recommended extensions installed?

@sandy081 sandy081 added the info-needed Issue requires more information from poster label Nov 3, 2021
@alokkumarsinha
Copy link
Author

alokkumarsinha commented Nov 3, 2021 •
edited
Loading

When I am building a java-based application, I want to use Graal Tools for Java Extension. But, whenever, I create a new java file, VS Code is recommending Microsoft's Java Extension (which is not right since I already downloaded Graal Extension). and no, I don't have or want to install MS's Java Extension (and all other ancilillary stuff it downloads). Please speak with [email protected] who has fuller context.

@sandy081
Copy link
Member

sandy081 commented Nov 3, 2021

Got it. May be we shall not recommend the language extension which we configured in the product, if user has already installed another extensions supporting the language.

@isidorn @chrisdias what do you think?

@sandy081 sandy081 added under-discussion Issue is under discussion for relevance, priority, approach and removed info-needed Issue requires more information from poster labels Nov 3, 2021
@isidorn
Copy link
Contributor

isidorn commented Nov 4, 2021

@sandy081 I think that makes sense in general.
However I would keep this issue open to gather more user feedback before we do any change.

@isidorn isidorn added the extension-recommendations Extension recommendations issues label Nov 4, 2021
@isidorn isidorn self-assigned this Nov 4, 2021
@isidorn isidorn added this to the Backlog milestone Nov 4, 2021
@gjsjohnmurray gjsjohnmurray mentioned this issue Nov 8, 2021
Closed
@atom0s
Copy link

atom0s commented Nov 8, 2021

Mentioned similar in my feature request here: #136644

Having a settings option to just completely disable 'pack recommendations' would be nice/ideal.

It's also sad to see this is basically just pushing Microsoft stuff. Kind of anti-competitive to other devs making useful extensions for things.

@alokkumarsinha
Copy link
Author

@isidorn How long will VS Code seek input before executing on a plan to address the original issue raised? Thanks, Alok

@atom0s
Copy link

atom0s commented Dec 6, 2021

@isidorn How long will VS Code seek input before executing on a plan to address the original issue raised? Thanks, Alok

Sadly, I don't think we'll see them actually fix this and will eventually be up to a third-party developer to make a 'block' for nonsense additions like this. If you check out my issue linked above, they completely derailed the conversation into something else and ignored my original post pretty much entirely.

It seems they are more interested in getting people to install as many Microsoft branded extensions as possible than to actually support the third-party community that made this tool what it is today.

@isidorn
Copy link
Contributor

isidorn commented Dec 7, 2021

This has only been open for 1 month. We are still waiting for additional user feedback.
We do not do things hastily. Thank you for your understanding.

@atom0s
Copy link

atom0s commented Dec 7, 2021

Care to link to the discussions that were had to have this feature implemented in the first place? Doesn't seem like there are any for it to be added and then not even given the option to disable it without just fully disabling all suggestions.

@graemerocher
Copy link

This behaviour is very annoying, can the priority on this one be increased please? It is painful to be continuously hassled to install plugins I do not want

@nickzhums
Copy link
Member

nickzhums commented Jan 5, 2022 •
edited
Loading

Hi @alokkumarsinha

image

Currently, GraalVM Tools for Java still automatically disables core features of Extension Pack for Java if both extension packs are present. Since two extension packs might have their specific scenarios, for example, Spring users still need to install the Extension Pack for Java for Spring development, simply disabling features in another extension doesn't seem the correct course of action.

It's very likely to for a user to two install both extensions for different purposes. I'm a bit skeptical about the automatic suppression of GraalVM Tools for Java. Do you know when this issue can be addressed?

Thanks

@graemerocher
Copy link

@nickzhums I think we need a recommendation on how to deal with this. Clearly the two extensions cannot be used at the same time so is there a way allow the user to choose one on a per workspace basis? Are there APIs for this? We need to know how this can be addressed and of course will address it.

Note I think it will also need to be addressed on the VSCode for Java side since if if the user chooses to use GraalVM Tools for Java then they shouldn't be prompted or continuously hassled to use another extension.

@isidorn
Copy link
Contributor

isidorn commented Jan 6, 2022

Thank you very much for your feedback.
Assigning to the February milestone so @sandy081 and me look into a solution for this then.

@isidorn isidorn modified the milestones: Backlog, February 2022 Jan 6, 2022
@kieferrm kieferrm mentioned this issue Feb 7, 2022
Closed
81 tasks
@sandy081 sandy081 added feature-request Request for new features or functionality extensions Issues concerning extensions and removed under-discussion Issue is under discussion for relevance, priority, approach labels Feb 11, 2022
@sandy081 sandy081 reopened this Feb 11, 2022
@isidorn
Copy link
Contributor

isidorn commented Feb 11, 2022 •
edited
Loading

We have pushed a fix for this. Please try it out from VS Code insiders on Monday and let us know how it goes.
We will no longer recommend the java pack when ASF.apache-netbeans-java is installed.

@isidorn isidorn closed this as completed Feb 11, 2022
@isidorn isidorn added the verification-needed Verification of issue is requested label Feb 11, 2022
@graemerocher
Copy link

Thank you!

sandy081 added a commit that referenced this issue Feb 11, 2022
@sandy081
#136301 - support whenNotInstalled for config based and exe recommend…
a0a9e5d 
…ations
@alokkumarsinha
Copy link
Author

alokkumarsinha commented Feb 11, 2022 via email

@sandy081
Copy link
Member

To verify:

  • Open VS Code (use fresh user data and extensions data directory)
  • Install ASF.apache-netbeans-java extension
  • Create a java file
  • Make sure there is no recommendation to install Java Extension Pack
  • Uninstall ASF.apache-netbeans-java extension and reload window
  • Create a java file
  • Make sure there is a recommendation to install Java Extension Pack

@alokkumarsinha
Copy link
Author

alokkumarsinha commented Feb 22, 2022 via email

@isidorn
Copy link
Contributor

isidorn commented Feb 22, 2022

Great, thanks @alokkumarsinha
Adding verified label.

@isidorn isidorn added the verified Verification succeeded label Feb 22, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

@sandy081 sandy081

Labels
extension-recommendations Extension recommendations issues extensions Issues concerning extensions feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
February 2022
Development

No branches or pull requests
7 participants
@graemerocher @atom0s @isidorn @gjsjohnmurray @sandy081 @nickzhums @alokkumarsinha