Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide platform "Copy As..." submenu #118208

Closed
joaomoreno opened this issue Mar 5, 2021 · 7 comments · Fixed by #118212
Closed

Provide platform "Copy As..." submenu #118208

joaomoreno opened this issue Mar 5, 2021 · 7 comments · Fixed by #118212
Assignees
@joaomoreno
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders menus Menu items and widget issues on-release-notes Issue/pull request mentioned in release notes verification-needed Verification of issue is requested verified Verification succeeded
Milestone
March 2021

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Mar 5, 2021 •
edited
Loading

Provide a editor/context/copy core submenu, in the editor context menu.
Also, a menuBar/edit/copy core submenu, in the top level menu bar Edit menu.

cc @alexr00, @eamodio (gitlens) for adoption once this is in.
@joaomoreno joaomoreno added feature-request Request for new features or functionality menus Menu items and widget issues labels Mar 5, 2021
@joaomoreno joaomoreno added this to the March 2021 milestone Mar 5, 2021
@joaomoreno joaomoreno self-assigned this Mar 5, 2021
joaomoreno added a commit that referenced this issue Mar 5, 2021
@joaomoreno
add "Copy As..." submenu
cd9611a 
fixes #118208
@joaomoreno joaomoreno mentioned this issue Mar 5, 2021
Merged
@rebornix
Copy link
Member

rebornix commented Mar 5, 2021

Quick question, once we have this sub menu. Should "Copy as Plain Text" and "Copy as Rich Text" (w/ syntax highlighting) as part of the menu? Also these two are builtin commands, do they always show at the very top?

@joaomoreno
Copy link
Member Author

Yes, I think so. cc @egamma

@eamodio
Copy link
Contributor

eamodio commented Mar 5, 2021

I'd think the Copy Relative Path should too

@kieferrm kieferrm mentioned this issue Mar 8, 2021
Closed
76 tasks
joaomoreno added a commit that referenced this issue Mar 15, 2021
@joaomoreno
Add "Copy As..." core submenu to editor context and Edit titlebar menu (
a4adb60 
#118212)

* add "Copy As..." submenu

fixes #118208

* bad editing

* address feedback

* menuBar/edit/copy menu
@alexr00
Copy link
Member

alexr00 commented Mar 16, 2021

Started adopting in GHPRI, and it works great. microsoft/vscode-pull-request-github#2574

@joaomoreno
Copy link
Member Author

@alexr00 I forgot to update the original post in this issue: there's also the menuBar/edit/copy submenu, in case you're interested in being there as well.

@alexr00
Copy link
Member

alexr00 commented Mar 17, 2021

@joaomoreno 👍 already adopted both menu entries in GHPRI.

@joaomoreno joaomoreno added the verification-needed Verification of issue is requested label Mar 22, 2021
@joaomoreno
Copy link
Member Author

This will be verified via @alexr00's feature. @alexr00 can you mark this as verified?

@alexr00 alexr00 added the verified Verification succeeded label Mar 22, 2021
@joaomoreno joaomoreno added the on-release-notes Issue/pull request mentioned in release notes label Mar 26, 2021
@eamodio eamodio mentioned this issue Mar 29, 2021
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders menus Menu items and widget issues on-release-notes Issue/pull request mentioned in release notes verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
March 2021
Development

Successfully merging a pull request may close this issue.

Add "Copy As..." core submenu to editor context and Edit titlebar menu microsoft/vscode
5 participants
@joaomoreno @eamodio @rebornix @alexr00 and others