Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All of the directories in the array doesn't exist. Update emmet.extensionsPath setting #118008

Closed
JacksonKearl opened this issue Mar 3, 2021 · 2 comments · Fixed by microsoft/vscode-emmet-helper#59
Closed

All of the directories in the array doesn't exist. Update emmet.extensionsPath setting #118008

JacksonKearl opened this issue Mar 3, 2021 · 2 comments · Fixed by microsoft/vscode-emmet-helper#59
Assignees
@rzhao271
Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
March 2021

Comments

@JacksonKearl
Copy link
Contributor

JacksonKearl commented Mar 3, 2021 •
edited
Loading

I have not configured this setting, so I'd expect to not see this error.

(Note this is only building from sources, disregard if you've already fixed)

image
@rzhao271 rzhao271 mentioned this issue Mar 3, 2021
Closed
rzhao271 added a commit that referenced this issue Mar 3, 2021
@rzhao271
Fixes #118008
dc17806
@rzhao271 rzhao271 added candidate Issue identified as probable candidate for fixing in the next release emmet Emmet related issues important Issue identified as high-priority labels Mar 3, 2021
@rzhao271 rzhao271 added this to the February 2021 milestone Mar 3, 2021
@rzhao271 rzhao271 added bug Issue identified by VS Code Team member as probable bug and removed candidate Issue identified as probable candidate for fixing in the next release important Issue identified as high-priority labels Mar 3, 2021
@rzhao271 rzhao271 modified the milestones: February 2021, March 2021 Mar 3, 2021
@rzhao271
Copy link
Contributor

rzhao271 commented Mar 3, 2021

Ok. I looked into the problem with @lancewl and we have concluded the following:

  1. This issue only affects OSS builds on the main branch, and therefore is not a candidate for the release/1.54 branch.
  2. This issue occurs due to a tragic accident between a new change in this repo and vscode-emmet-helper which worked together to make it so that the notification shows up not only when there's an actual issue with the extensionsPath, but also when the user didn't specify any.

I will push in a mitigation fix to the main branch. The actual fix will be out later.

rzhao271 added a commit that referenced this issue Mar 3, 2021
@rzhao271
Mitigates #118008, better fix TBD
0a49559
@lancewl lancewl mentioned this issue Mar 3, 2021
Merged
rzhao271 pushed a commit to microsoft/vscode-emmet-helper that referenced this issue Mar 3, 2021
@lancewl
Fix microsoft/vscode#118008 (#59)
a8f1ff0
rzhao271 added a commit that referenced this issue Mar 3, 2021
@rzhao271
Bump vscode-emmet-helper, fixes #118008
aaf7052
@rzhao271
Copy link
Contributor

rzhao271 commented Mar 3, 2021

\closedWith aaf7052

@RMacfarlane RMacfarlane added the verified Verification succeeded label Mar 25, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rzhao271 rzhao271

Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
March 2021
Development

Successfully merging a pull request may close this issue.

Fix vscode#118008 lancewl/vscode-emmet-helper
Fixes #118008 microsoft/vscode
4 participants
@RMacfarlane @rzhao271 @JacksonKearl and others