Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear terminal before launching another debuggee in terminal #116699

Closed
weinand opened this issue Feb 15, 2021 · 3 comments
Closed

Clear terminal before launching another debuggee in terminal #116699

weinand opened this issue Feb 15, 2021 · 3 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented Feb 15, 2021

In VS Code the DAP runInTerminal request tries to launch a new debug session in the same integrated terminal if the previous session has finished. A consequence of this approach is that the previous commands and output will remain visible in the integrated terminal which is confusing for some users.

This request asks for introducing a setting to automatically clear the integrated terminal before starting a new debug session.

@testforstephen this feature request is a replacement for your DAP feature request.

@weinand weinand added feature-request Request for new features or functionality debug Debug viewlet, configurations, breakpoints, adapter issues labels Feb 15, 2021
@weinand weinand added this to the On Deck milestone Feb 15, 2021
@weinand weinand self-assigned this Feb 15, 2021
@weinand weinand modified the milestones: On Deck, March 2021 Feb 22, 2021
@weinand
Copy link
Contributor Author

weinand commented Mar 16, 2021

@testforstephen the new feature is now available under a new setting "debug.terminal.clearBeforeReusing".

@testforstephen
Copy link

@weinand thanks. I tried in latest insider (2021-03-22) in macOS, overall it looks good. Just a minor concern about the clear behavior.

By default, launch a new debug session will auto keep the new terminal command at the beginning of my viewport.

Screen.Recording.2021-03-22.at.16.47.16.mov

But if i have scrolled the terminal manually, then launch in terminal won't clear the terminal and scroll to the latest terminal line.

Screen.Recording.2021-03-22.at.16.51.45.mov

@weinand
Copy link
Contributor Author

weinand commented Mar 22, 2021

@testforstephen thanks for testing.
Strange, scrolling should not have an effect because clearing the terminal is done by running the "clear" command in the terminal.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan
Projects
None yet
Development

No branches or pull requests

3 participants
@weinand @testforstephen and others